Comment 5 for bug 26305

Message-ID: <email address hidden>
Date: Mon, 28 Nov 2005 12:42:46 +0100
From: Martin Pitt <email address hidden>
To: Henrique de Moraes Holschuh <email address hidden>,
 <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#341060: initscript: completely broken

--pvezYHf7grwyp3Bc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

severity 341060 normal
tag 341060 unreproducible moreinfo
thanks

Hi Henrique!

Henrique de Moraes Holschuh [2005-11-28 0:22 -0200]:
> Package: sysfsutils
> Version: 1.3.0-3
> Severity: grave
> Justification: renders package unusable
>=20
> if [ "$f1" ] ;... is NOT valid shell syntax. Nor is [ ... -a "$f2" ].
> You're missing a "-n" in front of all bare string tests inside [ ].

The script runs fine with bash and dash, and [ "$foo" ] is common
practice and described in test(1):

       -n STRING
              the length of STRING is nonzero

       STRING equivalent to -n STRING

Downgrading severity since this runs fine at least on the majority of
installations.

So what exactly breaks for you? According to your initial report you
have /bin/sh linked to /bin/bash, do you use another shell?

Please give me the output of sh -nx /etc/init.d/sysfsutils if it
really breaks for you.

Thanks,

Martin
--=20
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org

In a world without walls and fences, who needs Windows and Gates?

--pvezYHf7grwyp3Bc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDiu01DecnbV4Fd/IRAiswAKCi5mZJUJT/UjpHdgPMHbLHvgrU3gCg4i+H
MUn7OiXdndrxkEcy4tIFBBA=
=w8DD
-----END PGP SIGNATURE-----

--pvezYHf7grwyp3Bc--