Comment on attachment 76150 pkexec: Set process environment from pam_getenvlist()
Review of attachment 76150: -----------------------------------------------------------------
Looks good but the the coding style is wrong
- curly-braces / indentation wrong - should use guint instead of int - should use 'n' as a counter/iterator, not 'i' (like the rest of the code)
These are style issues but consistency is important.
Comment on attachment 76150
pkexec: Set process environment from pam_getenvlist()
Review of attachment 76150: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
Looks good but the the coding style is wrong
- curly-braces / indentation wrong
- should use guint instead of int
- should use 'n' as a counter/iterator, not 'i' (like the rest of the code)
These are style issues but consistency is important.