Comment 7 for bug 1659567

Revision history for this message
Robie Basak (racb) wrote :

@Amos,

Could I have your advice on this please?

It seems that:

squid-deb-proxy has a static configuration in /etc/squid-deb-proxy/squid-deb-proxy.conf containing:
    acl blockedpkgs urlpath_regex "/etc/squid-deb-proxy/autogenerated/pkg-blacklist-regexp.acl"

Files in /etc/squid-deb-proxy/autogenerated are automatically generated, and in packaging we'd prefer not to have to alter /etc/squid-deb-proxy/squid-deb-proxy.conf dynamically.

This causes an emailed logrotation warning when logrotate calls "/usr/sbin/squid -f /etc/squid-deb-proxy/squid-deb-proxy.conf -k rotate". The warning comes from src/acl/Acl.cc because the ACL is empty. But in the default case, this is intentional.

I could suppress the warning with a grep in logrotate's call to "squid -k rotate", but this seems like an ugly hack. Is there any better way to suppress the warning, and if not, could we have one please? I also would prefer not to suppress *all* warnings, as anything else might be valid. It's just that this warning in particular is not valid in this case. Any time we use external ACL files, I think "empty file" is a valid case to avoid having to make "no ACL here" a special case that needs altering of the configuration file. Perhaps we could just drop this warning upstream?