Comment 19 for bug 19482

[Resending to LP due to buggered recipient address]

-------- Original Message --------
Subject: SRU proposal for 6.06.1's speex 1.1.11.1
Date: Sat, 04 Nov 2006 16:21:02 -0500
From: Daniel T. Chen <email address hidden>
Reply-To: <email address hidden>
To: <email address hidden>, <email address hidden>
CC: <email address hidden>, <email address hidden>

Hi Matt, Colin,

Early this morning, Jean-Marc Valin made me aware of an outstanding
segfault[0] affecting the speexenc executable for Dapper/AMD64 (release-
and arch-specific, purportedly only AMD64 is affected) upon attempting
to encode files. A straightforward fix[1] was applied upstream on 01
January 2006 and is present in Edgy's speex source package; only Dapper
is affected.

Attached please find a SRU debdiff against 6.06.1's speex source package.

% debdiff speex_1.1.11.1-1.dsc speex_1.1.11.1-1ubuntu0.1.dsc |diffstat
 speex-1.1.11.1/debian/changelog | 7 +++++++
 src/speexenc.c | 5 +++--
 2 files changed, 10 insertions(+), 2 deletions(-)

[0] https://launchpad.net/distros/ubuntu/+source/speex/+bug/19482
[1] https://trac.xiph.org/changeset/10684

Thanks,
--
Daniel T. Chen <email address hidden>
GPG key: 0xC88ABDA3

diff -u speex-1.1.11.1/debian/changelog speex-1.1.11.1/debian/changelog
--- speex-1.1.11.1/debian/changelog
+++ speex-1.1.11.1/debian/changelog
@@ -1,3 +1,10 @@
+speex (1.1.11.1-1ubuntu0.1) dapper-proposed; urgency=low
+
+ * Apply patch from https://trac.xiph.org/changeset/10684 fixing
+ speexenc segfault on AMD64 (Closes Ubuntu: #19482).
+
+ -- Daniel T Chen <email address hidden> Sat, 4 Nov 2006 16:09:19 -0500
+
 speex (1.1.11.1-1) unstable; urgency=low

   * New upstream release
only in patch2:
unchanged:
--- speex-1.1.11.1.orig/src/speexenc.c
+++ speex-1.1.11.1/src/speexenc.c
@@ -628,8 +628,9 @@

    /*Write header*/
    {
-
- op.packet = (unsigned char *)speex_header_to_packet(&header, (int*)&(op.bytes));
+ int packet_size;
+ op.packet = (unsigned char *)speex_header_to_packet(&header, &packet_size);
+ op.bytes = packet_size;
       op.b_o_s = 1;
       op.e_o_s = 0;
       op.granulepos = 0;