Ubuntu
source-highlight-qt package

  1. Bug #518317
  2. Comment #3

Comment 3 for bug 518317

Revision history for this message
Angel Abad (angelabad) wrote :

Hi Cesare, thanks for your care.

1. There is no need to move the Name field in copyright

Sorry, this was an error, fixed

2. You should add a short list of the new features of this release in changelog

According Debian/Ubuntu Policy[1] this file is for changes in package, not for changes in the
upstream source, for this purpose is the upstream's changelog file.

3. Versions for source-highlight and libsource-highlight-dev should be bumped in control

Why this? It depends on the same version PKG_CHECK_MODULES(SRCHILITE, [source-highlight >= 3.1.1])

4. Pls. make sure that Copyright entries in copyright are properly aligned

Ok, Fixed

5. Few files in this release are missing a copyright header. You should inform upstream.

Ok, I will inform him.

6. There is at least a new copyright owner to be listed in copyright, there is also at least a new file which is not licensed under the GPL

I ran licensecheck and I dont find any files with other license than GPL or with other owners.
And the AUTHORS file only list one upstream author

7. Upstream updated its copyright date to 2010 (at least in one file)

Ok, Fixed

8. Current Standards-Version is 3.8.4

Ok Fixed

9. I don' t think you have you done any testing of the package? There are plenty of test cases in the tarball and perhaps you will find some problems ...

I passed standard checks with make check tests and I have this output:

==================
All 5 tests passed
==================

[1] http://people.canonical.com/~cjwatson/ubuntu-policy/policy.html/ch-source.html#s-dpkgchangelog

Best Regards,