Comment 41 for bug 2038648

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Hi Arif,

Thanks for checking and confirming the locale changes are unrelated!

I suspected the locale difference were unrelated, but wanted a closer
look and clear understanding of why, before uploading, to ensure our
changes to Bionic demonstrate the required care to request an upload
in the exception criteria (to the Ubuntu archive for an ESM release).

I looked into this a bit more, and tracked these "new" locale files
to a behavior change in pkgstriptranslations (src:pkgbinarymangler)
if running on a PPA (do not strip), so the locale files are kept:
`INFO: Disabling pkgstriptranslations for PPA build`

So, for the regular/archive build (non-PPA), we expect the locale
files not to be present (as their strip should happen), therefore
their delta should drop -- and only expected changes would remain.

I confirmed this on a local build, by setting 'enable: true' in
`/etc/pkgbinarymangler/striptranslations.conf` and building the
package. The 'Disabling ... for PPA build' line is not present,
nor are the locale files:

$ dpkg-buildpackage -b -uc 2>&1 | tee ../build.log
$ grep pkgstriptranslations ../build.log
INFO: pkgstriptranslations version 138.18.04.2
pkgstriptranslations: processing sosreport (in debian/sosreport); do_strip: 1, oemstrip:
pkgstriptranslations: preparing translation tarball sosreport_4.4-1ubuntu0.18.04.2_amd64_translations.tar.gz...done
$ dpkg-deb -c ../sosreport_4.4-1ubuntu0.18.04.2_amd64.deb | grep locale
$

Uploading to Bionic.

cheers,
Mauricio

...

https://manpages.ubuntu.com/manpages/bionic/en/man1/pkgstriptranslations.1.html

This script also removes all gettext *.mo files below <pkg-build-dir>/usr/share/locale from all built binary packages.

...

$ curl -sL 'https://launchpadlibrarian.net/627169149/buildlog_ubuntu-bionic-amd64.sosreport_4.4-1ubuntu0.18.04.1_BUILDING.txt.gz' -o - | zcat >old.log
$ curl -sL 'https://launchpadlibrarian.net/735903734/buildlog_ubuntu-bionic-amd64.sosreport_4.4-1ubuntu0.18.04.2_BUILDING.txt.gz' -o - | zcat >new.log

$ grep pkgstriptranslations old.log new.log

old.log:INFO: pkgstriptranslations version 138.18.04.1
old.log:pkgstriptranslations: processing sosreport (in debian/sosreport); do_strip: 1, oemstrip:
old.log:pkgstriptranslations: preparing translation tarball sosreport_4.4-1ubuntu0.18.04.1_amd64_translations.tar.gz...done

new.log:INFO: pkgstriptranslations version 138.18.04.2
new.log:INFO: Disabling pkgstriptranslations for PPA build