Replace the Livepatch tab by an Ubuntu Pro one

[Sebastien Bacher]

* Impact

We want desktop integration with Ubuntu Pro, that will also replace the custom registration code we had for Livepatch which is integrated with the new service

* Test case

- ensure that the machine isn't attached to ubuntu pro (otherwise the screen would not be displayed) and is online
$ pro status
and `$ pro detach` if needed

- until the service is in production to try the magic workflow, edit /etc/ubuntu-advantage/uaclient.conf to set
contract_url: https://contracts.staging.canonical.com
then 'ua refresh config')
and use the non staging for token registration

- $ software-properties-gtk
-> the list of tabs should include an 'Ubuntu Pro' one and no 'Livepatch'

The Ubuntu Pro tab should state 'This machine is not covered by an Ubuntu Pro subscription', display a 'Enable Ubuntu Pro' button and have other controls inactive

- click 'Enable Ubuntu Pro'
-> A dialog 'Enable Ubuntu Pro' opens
-> the first option 'Enter code on ubuntu.com/pro/attach' is selected
-> a pincode is displayed under the option

- go to http//ubuntu.com/pro/attach and enter the pincode
-> after some seconds the software-properties UI should update and display a green mark and 'Valid token' label on the right of the pincode

- click 'Confirm'
-> you should get an authentification prompt

- enter your password
-> a spinner starts animating instead of the 'Valid token' label
-> once the attachment job is done the dialog is autoclosed
-> the UI should now state 'Ubuntu Pro support is enabled', under Security 'ESM Infra', 'ESM Apps' and 'Kernel Livepatch' should be displayed an enabled
(or without 'ESM Apps' if you don't have the current ubuntu-advantage-tools)

- check that the '$ pro status' output matches the UI one

- try enabling/disable options
-> verify that the 'pro status' change accordingly

- Click 'Disable Ubuntu Pro'
-> you get asked for confirmation and password
-> confirm that the UI is back to the original state and that 'pro status' confirm the system isn't attached to Ubuntu Pro anymore

- Go through the testcase again but selecting the 'Or add token manually' option, the steps should be similar

* Regression Potential

There could be problems in the UI
The new service could be not working as expected
Strings are new and currently have no translations

[Sebastien Bacher (seb128)]

The changes in Lunar, https://bugs.launchpad.net/ubuntu/+source/software-properties/0.99.30 (with some extra tweaks in the vcs pending upload)

[Steve Langasek (vorlon)]

An upload of software-properties to jammy-proposed has been rejected from the upload queue for the following reason: "SRU updates translatable strings but pot file update is missing in the source".

[Steve Langasek (vorlon)]

An upload of software-properties to focal-proposed has been rejected from the upload queue for the following reason: "SRU updates translatable strings but pot file update is missing in the source".

[Steve Langasek (vorlon)]

After discussion with Seb, have confirmed that the language pack gets updated strings injected from the package build, so does not need an updated .pot file in the source tarball.

I noticed in the review that there is a change to debian/control, dropping references to gir1.2-snapd-1. Normally we should avoid packaging changes in SRUs. In this case, I'm unable to find any references to snapd in the python source, so this looks safe.

There are also some translatable string differences between the SRUed version and the version in lunar, e.g.:

- <property name="label" translatable="yes">Enter code on ubuntu.com/pro/attach</property>
+ <property name="label" translatable="yes">Log in with Ubuntu One</property>

and:

- <property name="label" translatable="yes">&lt;b&gt;FIPS 140-2&lt;/b&gt;</property>
+ <property name="label">&lt;b&gt;FIPS 140-2&lt;/b&gt;</property>

This is a concern because it means these are new untranslated strings which our translators have had no head start on being able to translate in the devel series (which would make it a lot easier to copy the translations back for the identical strings to the stable series). While the window here is short enough that we might not have any new translations anyway, I think it's improper to introduce new English-language strings in this way, for users to be confronted with in an otherwise-localized system.

Anyway, I'm accepting this, but I would like to see some committment to following through with the translation team so they are aware there are new strings to be translated in the default desktop in a stable series, and have a chance to get updates into a language pack update for the next point release.

[Steve Langasek (vorlon)]

Hello Sebastien, or anyone else affected,

Accepted software-properties into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.24.32.19 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sebastien Bacher (seb128)]

Thanks Steve for the reviews and for pointing out that the strings were outdated in Lunar, we had some recent tweaks in the Vcs not uploaded to the archive yet. I've updated the package now, which resolves the 'Enter code on ubuntu.com/pro/attach' vs 'Log in with Ubuntu One'

We also somehow missed cherrypicking the commit that made 'FIPS 140-2' not-translatable to stable series. I don't think change that is worth an upload though since the only problem it could create is if some translators went out of their way to translate it in a stable serie to something that doesn't make sense and we can also resolve it by manually editing the template and reuploading the .pot to launchpad, no need of a package upload.

I've emailed the translators list to let them know about the new strings
https://lists.ubuntu.com/archives/ubuntu-translators/2023-January/007865.html

[Sebastien Bacher (seb128)]

I've tested 0.99.22.5 on 22.04, activating ubuntu pro through the magic workflow, detachig and activating again using the manual token one, it works as expected, marked as verified on J

[Sebastien Bacher (seb128)]

I've tested 0.99.9.10 on 20.04, activating ubuntu pro through the magic workflow, detachig and activating again using the manual token one, it works as expected, marked as verified on F

[Sebastien Bacher (seb128)]

The bionic upload failed to include a recent fix and failed verification, I uploaded 0.96.24.32.20 to address the problem now

[Brian Murray (brian-murray)]

Hello Sebastien, or anyone else affected,

Accepted software-properties into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.24.32.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sebastien Bacher (seb128)]

I've tested 0.96.24.32.20 on 18.04, activating ubuntu pro through the magic workflow, detachig and activating again using the manual token one, it works as expected, marked as verified on B

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-properties - 0.99.22.5

---------------
software-properties (0.99.22.5) jammy; urgency=medium

  * Replace Livepatch integration with Ubuntu Pro (lp: #2003527)

 -- Sebastien Bacher <email address hidden> Fri, 20 Jan 2023 11:58:10 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for software-properties has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-properties - 0.99.9.10

---------------
software-properties (0.99.9.10) focal; urgency=medium

  * Replace Livepatch integration with Ubuntu Pro (lp: #2003527)

 -- Sebastien Bacher <email address hidden> Fri, 20 Jan 2023 13:34:21 +0100

[Łukasz Zemczak (sil2100)]

So normally I wouldn't release the bionic version, as it's only been in -proposed 10 hours. However, as it's a time-critical fix from a product perspective AND the diff only touches the UA Attach code (which is being verified here), I think we can do this one-single-exception. Also, I got info from seb and confirmed that the same changesets are in all three series. Regression potential is low because of that. Let's proceed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-properties - 0.96.24.32.20

---------------
software-properties (0.96.24.32.20) bionic; urgency=medium

  * softwareproperties/gtk/DialogUaAttach.py: fix an incomplete backport
    of recent changes, fix an exception raised when opening the attach
    dialog (lp: #2003527)

software-properties (0.96.24.32.19) bionic; urgency=medium

  * Replace Livepatch integration with Ubuntu Pro (lp: #2003527)

 -- Sebastien Bacher <email address hidden> Wed, 25 Jan 2023 18:50:56 +0100