Comment 7 for bug 1157900

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

The real error here is that get_ppa_info_from_lp() has an “except:” line that catches all exceptions derived from BaseException, including KeyboardInterrupt and even SystemExit.

This is not recommended (see http://docs.python.org/3/howto/doanddont.html#except) and can lead to random bug errors like this one. I propose to change that line to “except NameError:” (which means that we failed to import urllib) or at least “except Exception:”.