Opting in to recommendations asks you to sign in with the wrong text
Bug #967064 reported by
Matthew Paul Thomas
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
software-center (Ubuntu) |
Fix Released
|
High
|
Gary Lasker | ||
Precise |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
1. Create a new admin user account and log in to it. (Or, once bug 967048 is fixed, log in to a guest session.)
2. Launch USC.
3. Click "Turn on Recommendations".
4. Wait a minute.
What happens: A sign-in dialog appears, saying "To reinstall previous purchases, sign in to the Ubuntu Single Sign-On account you used to pay for them."
What should happen: No sign-in dialog should appear.
<https:/
Related branches
lp:~gary-lasker/software-center/recommendations-sso-login-lp973612
- software-store-developers: Pending requested
-
Diff: 131 lines (+66/-4)2 files modifiedsoftwarecenter/backend/login_sso.py (+3/-2)
softwarecenter/ui/gtk3/widgets/recommendations.py (+63/-2)
lp:~gary-lasker/software-center/recommendations-sso-login-lp967064
Merged
into
lp:software-center
- software-store-developers: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsoftwarecenter/ui/gtk3/widgets/recommendations.py (+1/-1)
Changed in software-center (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in software-center (Ubuntu): | |
milestone: | none → ubuntu-12.04 |
Changed in software-center (Ubuntu): | |
status: | New → Triaged |
assignee: | nobody → Gary Lasker (gary-lasker) |
status: | Triaged → In Progress |
summary: |
- Opting in to recommendations asks you to sign in + Opting in to recommendations asks you to sign in with the wrong text |
Changed in software-center (Ubuntu): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
So the client needs to change so that: 1.0/profile/ (?P<uuid> [\dabcdef] {32})/$ [name=' api-anon- profile' ] API to opt-in
- if there is no token, we use the
api/
- if there is a token, we use what we had before
- if there is no token the server needs to provide a API for recommend_me that works without auth
- if there is a token, nothing will change
- if the user opts in for e.g. purchase or reviews use the authenticted submit_profile call on the next
submit_profile call (the one that is done regularly)