[GTK3] "What's New" and "Top Rated" tiles have different widths

Bug #833697 reported by Matthew Paul Thomas
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Matthew McGowan

Bug Description

software-center-gtk3 trunk r2202, Ubuntu Ocelot

1. Launch USC.
2. Maximize the window.

What happens:
1. The "What's New" and "Top Rated" tiles are the same width.
2. The "Top Rated" tiles get wider than the "What's New" tiles.

What should happen: At any moment, all visible tiles should be the same width.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :
Revision history for this message
Aaron Peachey (aaronp) wrote :

This is a consequence of the change I made to the tiles to remove the word 'reviews' and add the number of ratings in brackets after the stars. At the time I made a change to dynamically size the tiles so that they were at least as big as the widest 'stars + ratings + icon + padding' combined width. This can be different for each tile though.
We'll need to find a happy medium (i.e. maximum size of the widest tile on display needs to be the size of all other tiles on display) in order to ensure the tiles are all the same size, but this will result in some tiles having far more whitespace than others.

Revision history for this message
Matthew McGowan (mmcg069) wrote :

With the exception of the icon in the FeaturedTile, everything is text, which means we should just be able to set the width request to some multiple of the current em-value....

Revision history for this message
Matthew McGowan (mmcg069) wrote :

ok, linked branch has an approach i think should def work... featured tile width is derived from a global, so aaron your approach is maintained except we only use the calc'd req_width if it is larger than the current global featured_tile_width value

along the lines of:
global _featured_tile_width
_featured_tile_width = max(req_width, _featured_tile_width)

all featured tiles throughout software center will have the same width as a consequence of this change. Hope this is desirable.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I think the minimum width could do with an increase of 30% or so ... but testing r2144 of that branch, it does seem to fix the bug described here. Thanks Matthew!

Changed in software-center (Ubuntu):
assignee: nobody → Matthew McGowan (mmcg069)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Branch merged, thanks Matt!

Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 4.1.21

software-center (4.1.21) oneiric; urgency=low

  [ Kiwinote ]
    - add credits for the new icon (LP: #834882)
  * a stash of unicode fixes to make s-c-gtk3 usable around the world
    (LP: #831865, LP: #834409, LP: #834312)
  * softwarecenter/db/update.py:
    - fix reinstall previous purchases (LP: #834984)
  * softwarecenter/ui/gtk3/panes/availablepane.py:
    - set title for 'previous purchases' list view (LP: #833960)
  * softwarecenter/ui/gtk3/panes/softwarepane.py:
    - fix None.copy() such that switching panes works again (LP: #834196)
  * softwarecenter/ui/gtk3/widgets/buttons.py:
    - escape application name in tiles (LP: #835876)

  [ Jacob Johan Edwards ]
  * softwarecenter/ui/gtk3/panes/softwarepane.py:
    - fix the spinner display when loading slow views (LP: #830682)

  [ Gabor Kelemen ]
  * po/POTFILES.in,
    - update per latest configuration, add new gtk3 files

  [ Matthew McGowan ]
  * softwarecenter/ui/gtk3/widgets/buttons.py :
    - resize fix for Top Rated and What's New tiles (LP: #833697)
  * softwarecenter/ui/gtk3/views/catview_gtk.py,
    - disable the rendering of the checkboard pattern in the
      grid views (at request of mpt)
   * lp:~mmcg069/software-center/description-tweaks:
     - fix badly rendered package descriptions, other tweaks
       (LP: #833954)
   * lp:~mmcg069/software-center/globalpane-themeability:
     - various theming fixes (LP: #828092, LP: #830681,
       LP: #830738 and LP: #838382)

  [ Gary Lasker ]
  * software-center,
    - enable CJK support in Xapian (LP: #745243)
  * po/software-center.pot:
    - refresh .pot file
  * softwarecenter/ui/gtk/widgets/thumbnail.py:
    - fix missing icon in theme to let non-gtk3 version
      launch again, also fixes all gtk unit tests
  * test/test_database.py:
    - update unit test

  [ Didier Roche ]
  * softwarecenter/ui/gtk3/panes/installedpane.py,
    - brings back OneConf to software center gtk3 with a fresh new design
      (LP: #838623)
  * debian/control:
    - depends on latest oneconf
 -- Gary Lasker <email address hidden> Thu, 01 Sep 2011 11:55:14 -0400

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments