software center doesn't let you review installed apps without restarting

Bug #769439 reported by Spike Burch on 2011-04-23
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Medium
Gary Lasker
Natty
Medium
Gary Lasker

Bug Description

Binary package hint: software-center

TEST CASE:

1. Open Software Center version 4.0 (stock Natty).
2. Navigate to the details view for any package that is not yet installed.
3. Note that the string in the reviews section reads "You need to install this app before you can review it"
4. Install the package.
5. After the package installation is complete, note that the string still reads "You need to install this app before you can review it"
6. Uninstall the package.
7. Close Software Center and upgrade to version 4.0.1 in natty-proposed.
8. Open Software Center and navigate back to the test package.
9. Verify that the string again reads "You need to install this app before you can review it" (as it is not installed)
10. Install the package.
11. After installation is complete, verify that the text has changed to "Be the first to review it" or "Write your own review", and when clicked brings up the reviews login dialog.

---

After installing an application, software center still says "you need to install this app before you can review it." The only way to review an app is to close software center, and then re-open it after installation.

str (from dupe bug 765396):
1- go to an app in the software centre (i used radio-tray)
2- click install, authenticate, wait for this to complete
3- (optionally) launch the application and play with it

what should happen:
 - i can enter comments about the application in the software centre
what does happen:
 - it still says "you need to install this application" etc

The problem seems to be that the reviews section ought to reload or update after installation but it does not. The inverse problem appears after deinstallation (ie you can still review it.)

(Separately, it might be reasonable to let people review software they previously tried and then deinstalled: Android Market does that for example.)

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: software-center 4.0
ProcVersionSignature: Ubuntu 2.6.38-8.42-generic-pae 2.6.38.2
Uname: Linux 2.6.38-8-generic-pae i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Sat Apr 23 05:20:43 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Beta i386 (20110413)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US:en
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: software-center
UpgradeStatus: No upgrade log present (probably fresh install)

Spike Burch (spikeb) wrote :
Changed in software-center (Ubuntu):
status: New → Confirmed
Changed in software-center (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → Medium
assignee: nobody → Gary Lasker (gary-lasker)
description: updated
Michael Vogt (mvo) wrote :

Thanks a lot for this Gary, I merged it into trunk and the 4.0 branch and its ready for a SRU! Having a testcase for it would be nice (e.g. in tests/test_appdetails_view.py) but I think the code is pretty straightforward so I merged it.

Changed in software-center (Ubuntu Natty):
milestone: none → ubuntu-11.04
milestone: ubuntu-11.04 → natty-updates
Gary Lasker (gary-lasker) wrote :

Test case added. Thanks mvo!

Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Changed in software-center (Ubuntu Natty):
status: In Progress → Fix Committed
description: updated

Accepted software-center into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Spike Burch (spikeb) wrote :

Installed update from natty-proposed. It fixed the problem.

Martin Pitt (pitti) on 2011-05-03
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 4.0.1

---------------
software-center (4.0.1) natty-proposed; urgency=low

  [ Michael Vogt ]
  * debian/control:
    - point to 4.0 bzr branch
  * merged lp:~mmcg069/software-center/Bug635994, many thanks
    (LP: #635994)
  * utils/submit_review.py:
    - fix missing translation (LP: #770439)
  * utils/submit_review.py:
    - improve logging on SSO failure (LP: #773214)
    - do not translate "appname" as ubuntu-sso-login will fail
      for translated names with utf8 chars (LP: #773214)
  * softwarecenter/db/reviews.py:
    - apply review sorting (LP: #773289)
  * softwarecenter/app.py:
    - do not translate "appname" as ubuntu-sso-login will fail
      for translated names with utf8 chars (LP: #773214)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/translation-fixes-lp770439:
    - fix translation not showing up (LP: #770439)
  * softwarecenter/view/appdetailsview_gtk.py,
    softwarecenter/view/widgets/reviews.py,
    test/test_appdetails_view.py:
    - enable writing a review immediately after the package
      installation is complete, add test case (LP: #769439)
 -- Michael Vogt <email address hidden> Fri, 29 Apr 2011 16:40:32 +0200

Changed in software-center (Ubuntu Natty):
status: Fix Committed → Fix Released
Martin Pitt (pitti) wrote :

Gary, can you please fix these and the other 4 bugs in the recent SRU in oneiric as well? I suppose they are already, but the tasks are still open.

Changed in software-center (Ubuntu):
milestone: natty-updates → oneiric-alpha-1
Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
tags: added: testcase
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers