Comment 5 for bug 709408

Revision history for this message
Aaron Peachey (aaronp) wrote :

Fix in branch attached.
Note, the fix only stops an exception from being output on a 404 error being found and handles it by simply logging a warning instead. The actual behaviour of Software Center for this scenario is unchanged, as there was nothing wrong with what it was doing before (i.e. it was already adequately handling the fact that it couldn't retrieve reviews in the UI).

We need to determine if we will allow reviews to be submitted for any origin other than 'ubuntu'. If not, I can revise this fix further to not even bother trying to retrieve them if the origin is not ubuntu. I can't imagine why we would want to accept reviews for apps in a PPA, because we could reasonably assume once a user has added a PPA they are doing so because they know what they want to install. If this is the case, are there any other origins for which we would need to accept (and subsequently retrieve) reviews?