Back button causes brief display of wrong page

Bug #704719 reported by Tom Harris on 2011-01-19
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Medium
Alex Eftimie

Bug Description

Binary package hint: software-center

Sometimes pressing the back button causes a different page from the history to be shown.

How to reproduce:
1) Search for a package (Package A) and click "More Info"
2) Click "Get Software" in navigation breadcrumb
3) Search for a different package (Package B) and click "More Info"
4) Click back button

What happens:
Package A's info is briefly shown before returning to search results

What should happen:
Return straight to search results

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: software-center 3.0.7
ProcVersionSignature: Ubuntu 2.6.35-23.41-generic-pae 2.6.35.7
Uname: Linux 2.6.35-23-generic-pae i686
NonfreeKernelModules: wl
Architecture: i386
Date: Wed Jan 19 00:33:43 2011
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release i386 (20101007)
PackageArchitecture: all
ProcEnviron:
 LANG=en_GB.utf8
 SHELL=/bin/bash
SourcePackage: software-center

Tom Harris (tom-harris) wrote :
Kiwinote (kiwinote) wrote :

Hi Tom! Thanks for noticing and reporting this issue.

Changed in software-center (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Alex Eftimie (alexeftimie) wrote :

Hi, the problem is that in NavigationItem.navigate_to, line 148, a call to available_pane.app_details_view.show_app(self.current_app) is made, and a current_app for applist view exists.

 I attached a patch fixing this by setting current_app to None if the current view in AvailablePane is PAGE_APPLIST.

What do you think?

Alex Eftimie (alexeftimie) wrote :

As pointed on #ubuntu-desktop by kiwinote, the previous patch breaks the File menu.

Please see the attached patch for another approach, changing the behavior only on NavigationItem, making it aware of the current view.

tags: added: patch
Changed in software-center (Ubuntu):
status: Triaged → Fix Committed
assignee: nobody → Alex Eftimie (alexeftimie)
tags: removed: patch
Launchpad Janitor (janitor) wrote :
Download full text (3.7 KiB)

This bug was fixed in the package software-center - 3.1.25

---------------
software-center (3.1.25) natty; urgency=low

  [ Kiwinote ]
  * data/ui/SoftwareCenter.ui:
    - mark the back/forward actions as translatable (LP: #742129)
  * softwarecenter/db/database.py,
    softwarecenter/models/appstore.py,
    softwarecenter/view/availablepane.py,
    others:
    - make custom lists work (LP: #712903)
  * softwarecenter/app.py,
    softwarecenter/distro/Ubuntu.py,
    softwarecenter/view/widgets/pathbar_gtk_atk.py:
    - when the supported filter is set to supported_only, navigate up if:
      - we are in a details view of an app which is not supported (LP: #480827)
      - we are in a list view which becomes empty
  * softwarecenter/app.py,
    softwarecenter/view/catview_gtk.py:
    - correctly count the nr of apps displayed in the recommended category and
      update it when needed (LP: #735634)
    - only display subcategories if they are non-empty (LP: #419270)
  * softwarecenter/backend/weblive.py:
    - don't crash if we try to delete a non-existent file (LP: #743511)
  * softwarecenter/db/reviews.py,
    softwarecenter/distro/Ubuntu.py:
    - fallback to ReviewLoaderJsonAsync when we can't use multiprocessing
      (LP: #741069)
    - fixes to make ReviewLoaderJsonAsync 'work' (ie most common cases)
  * softwarecenter/db/update.py:
    - don't import softwarecenter.log
  * softwarecenter/view/appdetailsview_gtk.py:
    - don't draw random boxes when we have an error layout (LP: #739269)
    - retire share button as we now have full microblogging support in the
      review dialog (LP: #592619, LP: #743765)
  * softwarecenter/view/appview.py:
    - correctly refresh listview when supported filters are changed
  * softwarecenter/view/catview.py:
    - if a category has subcategories, then category.query should include all
      items included in the subcategories, not a subset of these
  * softwarecenter/view/widgets/pathbar_gtk_atk.py:
    - avoid having a half-height pathbar (LP: #743614)
  * refresh .pot file

  [ Gary Lasker ]
  * softwarecenter/view/widgets/reviews.py:
    - fix crash if app_version is not defined when
      calling upstream_version_compare (LP: #746120)
  * softwarecenter/view/purchaseview.py:
    - disconnect webkit signal handlers when the webkit view
      is not showing (LP: #696861)
    - support 'user_cancelled' from the software-center-agent
      (LP: #641321)
  * softwarecenter/view/softwarepane.py,
    softwarecenter/view/widgets/actionbar.py:
    - animate the action bar show/hide
  * softwarecenter/view/appview.py:
    - in the AppViewFilter, also consider apps in the for-purchase
      channel as available; this allows them to show up in
      e.g. What's New (LP: #746679)

  [ Michael Vogt ]
  * softwarecenter/db/update.py:
    - ensure the iconname that comes from the software-center-agent
      does not contain a ".", the icon cache gets confused otherwise
  * merged lp:~evfool/software-center/sfix672229, many thanks to
    Robert Roth (LP: #672229)
  * merged lp:~alexeftimie/software-center/fix-704719-briefly-wrong-display,
    many thanks to Alex Eftimie (LP: #704719)
  * softwarecenter/view/purc...

Read more...

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers