Pathbutton doesn't expose text to accessibility aids

Bug #526384 reported by Matthew Paul Thomas on 2010-02-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
High
Unassigned

Bug Description

Binary package hint: software-center

1. In Ubuntu Software Center, navigate to "Get Software" > "Games" > "Arcade" > "Bomber".
2. In Accerciser, navigate to software-center > Ubuntu Software Centre > (blank) > (split pane) > (page tab list) > (first page tab) > (panel) > (filler) > (filler) > (first element).

What happens: The element has Name "" and Children "0".

What should happen:
* The element has Name "You are here:" and Children "4".
* There are four child elements with Role "push button": "Get Software", "Games", Arcade", and "Bomber".

Willie Walker suggests these two resources for helping with this:
http://library.gnome.org/devel/accessibility-devel-guide/stable/gad-custom.html.en
http://mail.gnome.org/mailman/listinfo/gnome-accessibility-list

Michael Vogt (mvo) wrote :

I commited some fixes for this into bzr, but it appears for a proper fix we need to implement "atk.Component" in Pathbar and PathPart to make it really work.

Changed in software-center (Ubuntu):
status: New → Triaged
importance: Undecided → High
description: updated
tags: added: a11y
Michael Vogt (mvo) wrote :

We have a branch for this now that adds the following new strings:

+#: ../softwarecenter/view/widgets/backforward.py:60
+msgid "History Navigation"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/backforward.py:61
+msgid ""
+"Click either the back or forwards buttons to navigate your viewed pages "
+"history"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/backforward.py:72
+#: ../softwarecenter/view/widgets/backforward.py:86
+msgid "Back Button"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/backforward.py:73
+#: ../softwarecenter/view/widgets/backforward.py:87
+msgid "Click here to navigated backwards through your viewed pages history"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/backforward.py:78
+#: ../softwarecenter/view/widgets/backforward.py:92
+msgid "Forward Button"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/backforward.py:79
+#: ../softwarecenter/view/widgets/backforward.py:93
+msgid "Click here to navigated forwards through your viewed pages history"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/pathbar_gtk_atk.py:46
+msgid "You are here:"
+msgstr ""
+
+#: ../softwarecenter/view/widgets/pathbar_gtk_atk.py:279
+#, python-format
+msgid "Click here to navigate to the %s page"
+msgstr ""

Michael Vogt (mvo) wrote :

The lp:~mmcg069/software-center/pathbar-atk contains fixes for this.

Michael Vogt (mvo) wrote :

It works well in accerciser and shows the right releations.

Matthew Paul Thomas (mpt) wrote :

In this branch, but not in trunk r683, the Back and Forward buttons don't work: they're always insensitive.

Because of that bug, I can't test whether the description for the Back and Forward buttons work. I don't think it's useful to have a description for the buttons as a pair; a description just for each button should be fine.

The descriptions for the individual pathbutton elements work.

"Click here to navigated" is not correct grammar, and I doubt that it's appropriate for Orca descriptions to include "Click here to" anyway. I suggest changing each occurrence of "Click here to navigated" to "Navigates", e.g. "Navigates to the %s page."

Matthew McGowan (mmcg069) wrote :

Hi mpt,

backforward buttons seem fine here. How did you test? As for the atk strings i can modify easily.

Michael Vogt (mvo) on 2010-04-09
Changed in software-center (Ubuntu):
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 1.1.25

---------------
software-center (1.1.25) lucid; urgency=low

  [ Gary Lasker ]
  * softwarecenter/view/viewswitcher.py:
    - fix intermittent AttributeError if a model doesn't
      exist when checking node expanded state (LP: #554388)
  * softwarecenter/view/viewswitcher.py:
    - fix nasty list view errors when disabling partner
      repository (LP: #556995)
  * softwarecenter/view/appview.py:
    - fix intermittent AttributeError in row selection
      (LP: #552224)
  * softwarecenter/view/availablepane.py:
    - fix double call to set_category method
  * softwarecenter/view/channelpane.py,
    softwarecenter/view/installedpane.py:
    - fix bug where clicking the "Search Results" navigation
      button in the "Installed View" or in a PPA/channel
      view has no effect (LP: #559732)
  * softwarecenter/view/channelpane.py:
    - fix bug where selecting a new PPA/channel while
      a search is in effect in the current PPA/channel
      does not display the new PPA/channel (LP: #559742)

  [ Michael Vogt ]
  * softwarecenter/apt/aptcache.py:
    - add file monitor to detect changes in the dpkg status
      when apt is run outside of software-center (LP: #432555)
  * softwarecenter/view/appdetailsview.py:
    - only show "needs updating" message if we have a component
      associated with the software-item (LP: #542892)
  * softwarecenter/db/database.py:
    - when we have no package and no information no how to get it,
      display unavailable message instead of a empty summary line
  * merged lp:~mmcg069/software-center/pathbar-atk
    - this makes the pathbar on top fully accessible with e.g.
      orca (LP: #526384). Also fixes intermittent TypeError bug
      (LP: #558895) and nav button visual artifact when selecting
      a channel (LP: #531724). Many thanks!
  * softwarecenter/view/appview.py:
    - avoid blocking if a operation takes long

  [ Zygmunt Krynicki ]
  * softwarecenter/view/appdetailsview.py:
    - use package name when application name is not available (LP: #549011)
 -- Michael Vogt <email address hidden> Sat, 10 Apr 2010 16:29:10 +0200

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers