Comment 12 for bug 1002271

Sure thank you.

On 6/20/12, Gary Lasker <email address hidden> wrote:
> NOTE: This fix was actually released in software-center 5.2.2.1, but due
> to a copy error the changelog entry appears for this release too.
>
> Note also that since this fix has appeared in precise-updates, the
> number of occurances of this bug on errors.ubuntu.com has dropped
> dramatically and should go to zero as more people update to the fixed
> version.
>
> Based on this I'll mark this as verification-done, for the purposes of
> the current SRU.
>
> Thanks!
>
> ** Description changed:
>
> + SRU TEST CASE:
> + 1. Update to the version of software-center in precise-proposed.
> + 2. Launch Ubuntu Software Center from a terminal window as shown:
>
> - From errors.ubuntu.com , this looks like a regression in the new
> capitalize code:
> + $ software-center
> +
> + 3. Navigate and view the details page for a few different packages. Choose
> packages from different categories, etc.
> + 4. Verify that crash stacktrace shown below never appears in the terminal
> window.
> +
> + SRU REGRESSION POTENTIAL:
> + Regression risk is negligible. This is a single line fix that checks for a
> zero-length string before calling capitalize() on it, and this prevents the
> crash reported in this bug.
> +
> + ---
> +
> + From errors.ubuntu.com , this looks like a regression in the new
> + capitalize code:
>
> Traceback (most recent call last):
> - File
> "/usr/share/software-center/softwarecenter/ui/gtk3/widgets/cellrenderers.py",
> line 390, in do_render
> - is_rtl)
> - File
> "/usr/share/software-center/softwarecenter/ui/gtk3/widgets/cellrenderers.py",
> line 165, in _render_summary
> - layout.set_markup(self.model.get_markup(app), -1)
> - File
> "/usr/share/software-center/softwarecenter/ui/gtk3/models/appstore2.py",
> line 192, in get_markup
> - summary = capitalize_first_word(self.db.get_summary(doc))
> - File "/usr/share/software-center/softwarecenter/utils.py", line 128, in
> capitalize_first_word
> - if string[0].isalpha() and not string[0].isupper():
> +   File
> "/usr/share/software-center/softwarecenter/ui/gtk3/widgets/cellrenderers.py",
> line 390, in do_render
> +     is_rtl)
> +   File
> "/usr/share/software-center/softwarecenter/ui/gtk3/widgets/cellrenderers.py",
> line 165, in _render_summary
> +     layout.set_markup(self.model.get_markup(app), -1)
> +   File
> "/usr/share/software-center/softwarecenter/ui/gtk3/models/appstore2.py",
> line 192, in get_markup
> +     summary = capitalize_first_word(self.db.get_summary(doc))
> +   File "/usr/share/software-center/softwarecenter/utils.py", line 128, in
> capitalize_first_word
> +     if string[0].isalpha() and not string[0].isupper():
> IndexError: string index out of range
>
> ** Description changed:
>
> +
> + NOTE: This fix was actually released in software-center 5.2.2.1, but due
> to a copy error the changelog entry appears for this release too.
> +
> SRU TEST CASE:
> 1. Update to the version of software-center in precise-proposed.
> 2. Launch Ubuntu Software Center from a terminal window as shown:
>
> - $ software-center
> +   $ software-center
>
> 3. Navigate and view the details page for a few different packages. Choose
> packages from different categories, etc.
> 4. Verify that crash stacktrace shown below never appears in the terminal
> window.
>
> SRU REGRESSION POTENTIAL:
> Regression risk is negligible. This is a single line fix that checks for a
> zero-length string before calling capitalize() on it, and this prevents the
> crash reported in this bug.
> +
> + NOTE also that since this fix has been released in Precise, the number
> + of occurrances has dropped dramatically on errors.ubuntu.com.
>
> ---
>
> From errors.ubuntu.com , this looks like a regression in the new
> capitalize code:
>
> Traceback (most recent call last):
>   File
> "/usr/share/software-center/softwarecenter/ui/gtk3/widgets/cellrenderers.py",
> line 390, in do_render
>     is_rtl)
>   File
> "/usr/share/software-center/softwarecenter/ui/gtk3/widgets/cellrenderers.py",
> line 165, in _render_summary
>     layout.set_markup(self.model.get_markup(app), -1)
>   File
> "/usr/share/software-center/softwarecenter/ui/gtk3/models/appstore2.py",
> line 192, in get_markup
>     summary = capitalize_first_word(self.db.get_summary(doc))
>   File "/usr/share/software-center/softwarecenter/utils.py", line 128, in
> capitalize_first_word
>     if string[0].isalpha() and not string[0].isupper():
> IndexError: string index out of range
>
> ** Tags removed: verification-needed
> ** Tags added: verification-done
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1002735).
> https://bugs.launchpad.net/bugs/1002271
>
> Title:
> REGRESSION: crash in cell renderer
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/1002271/+subscriptions
>

--
Thanks,
Vivek

http://in.linkedin.com/in/vivektaparia

Think GREEN. Please consider the environment before printing this email.