Man page is incorrect

Bug #66174 reported by Mark Rose on 2006-10-14
10
Affects Status Importance Assigned to Milestone
showfsck (Ubuntu)
Low
Emmet Hikory

Bug Description

Someone took the debian man page template and didn't fill it properly. The man page doesn't document the command what-so-ever, but there's a bunch of stuff about Foo and Bar. lol

Dan O'Huiginn (daniel-ohuiginn) wrote :

Confirmed. To quote to current man-page:
"showfdisk - programs to do something.....This manual page documents briefly the showfdisk, and bar commands."

Tagging 'ubuntulove' in the hope that somebody will make this less funny and more useful.

Changed in showfsck:
importance: Undecided → Low
status: Unconfirmed → Confirmed
David Futcher (bobbo) wrote :

The original developer and packager Vincent Danjean has disappeared from Launchpad. I have rewritten the man page (attatched) but have no skills when it comes to building packages. The man edit came from 'sudo apt-get source showfsck' so i have all the debian stuff which is also in the branch. Hopefully someone can put together a package for this.

David Futcher (bobbo) on 2007-12-08
Changed in showfsck:
assignee: nobody → bobbo
David Futcher (bobbo) wrote :

Working on the old debian source i have built a working package for the code in the branch. It builds fine but i now have no idea how to get the new package in the repos. So a fully packaged patch is available, once i work out how to get things into the repos.

I made a deb for this. Attached is the debdiff.

Changed in showfsck:
assignee: bobbo → nobody
Siegfried Gevatter (rainct) wrote :

Thanks for contributing to Ubuntu! Some comments about your debdiff:

 - In the changelog, a "(LP: #66174)" on the end of the "Fixed man page" line is missing; this will close this bug automatically once the package is in Ubuntu. Also, please indicate in what file you fixed the typo.

 - The description in debian/control should start in lowercase, as it was. You have to imagine the description as the continuation of the sentence "showsfck is a...", so it should be rather something like: "showsfck is a | tool to show the number of reboots before next forced fsck".

 - Do not remove the maintainer, but rename the field to XSBC-Original-Maintainer, and add the line "Maintainer: Ubuntu MOTU Developers <email address hidden>" before it; also notice this in the changelog. For more information, see: https://wiki.ubuntu.com/DebianMaintainerField . Note: if you have package ubuntu-dev-tools installed, you can do this automatically by executing "update-maintainer" inside the source directory.

 - Do not change debian/copyright. Even if you modified it, it was still debianized by Vincent Danjean (don't worry, your contribution will still be recognized in the changelog ;)), and the "Author:" line refers to the upstream author, not the debian packaging. The only change you could do in this file is replace "Author(s):" by "Author:", as there is only one.

Thanks again!

David Futcher (bobbo) wrote :

Fixed debdiff. Makes all the changes listed above.

Siegfried Gevatter (rainct) wrote :

Some of my previous comments still apply...

David Futcher (bobbo) wrote :

Yet again, here is debdiff 3. Think this is right.

David Futcher (bobbo) wrote :

Debdiff number 4 (Yep it is my first time doing this)

Emmet Hikory (persia) on 2007-12-09
Changed in showfsck:
assignee: nobody → persia
status: Confirmed → In Progress
assignee: persia → bobbo
Daniel Holbach (dholbach) wrote :

- Is the update to debhelper (>= 4.2.0) needed? It seems that it just adds delta to the Debian version.
- not sure the "Author(s): Vincent Danjean" is worth it either - it'd help if it went to Debian too.

Other than that: good work.

David Futcher (bobbo) wrote :

Debdiff fixed for Daniels recommendations. Rolled debhelper back to 4.1.0 and reverted change to Author(s) line.

Emmet Hikory (persia) wrote :

Thanks for your work on this. This package has an odd history, so that it appears to be an Ubuntu-local package, but actually was once brought in from an alternate repository, and so the versioning is tricky. There are two courses of action that would make sense to me: either reversion your candidate as 1.3ubuntu1 or (better), coordinate with Vincent, and either create a 1.4ubuntu1 based on http://www-id.imag.fr/Laboratoire/Membres/Danjean_Vincent/deb.html#showfsck or feed your changes there, and submit a candidate for 1.5. Essentially, while I think the changes are good, I don't think there should be two different showfsck_1.4.tar.gz files on the internet, if this can be avoided.

I've unsubscribed ubuntu-universe-sponsors pending this coordination. Please resubscribe once a new candidate is prepared.

David Futcher (bobbo) wrote :

Sorry for the delay with this, been a bit busy. I have repackaged this as showfsck-1.3ubuntu1.

Emmet Hikory (persia) on 2008-01-08
Changed in showfsck:
assignee: bobbo → persia
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package showfsck - 1.3ubuntu1

---------------
showfsck (1.3ubuntu1) hardy; urgency=low

  * Fixed man page (LP: #66174)
  * showfsck: Fixed spelling/grammar in error message
  * Edited maintainer field to conform with DebianMaintainerField specification

 -- David Futcher <email address hidden> Sat, 08 Dec 2007 20:33:16 +0000

Changed in showfsck:
status: Fix Committed → Fix Released
Emmet Hikory (persia) wrote :

Uploaded. Thanks. A merge with 1.4 upstream would be welcome.

Changed in showfsck:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers