Comment 5 for bug 66174

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Thanks for contributing to Ubuntu! Some comments about your debdiff:

 - In the changelog, a "(LP: #66174)" on the end of the "Fixed man page" line is missing; this will close this bug automatically once the package is in Ubuntu. Also, please indicate in what file you fixed the typo.

 - The description in debian/control should start in lowercase, as it was. You have to imagine the description as the continuation of the sentence "showsfck is a...", so it should be rather something like: "showsfck is a | tool to show the number of reboots before next forced fsck".

 - Do not remove the maintainer, but rename the field to XSBC-Original-Maintainer, and add the line "Maintainer: Ubuntu MOTU Developers <email address hidden>" before it; also notice this in the changelog. For more information, see: https://wiki.ubuntu.com/DebianMaintainerField . Note: if you have package ubuntu-dev-tools installed, you can do this automatically by executing "update-maintainer" inside the source directory.

 - Do not change debian/copyright. Even if you modified it, it was still debianized by Vincent Danjean (don't worry, your contribution will still be recognized in the changelog ;)), and the "Author:" line refers to the upstream author, not the debian packaging. The only change you could do in this file is replace "Author(s):" by "Author:", as there is only one.

Thanks again!