Comment 2 for bug 645862

Revision history for this message
Jim Nelson (yorba-jim) wrote :

Filenames are not used to detect duplicates with Shotwell. (Obviously if it's the same file *path* it's a duplicate, but that's a special case.) We do an MD5 hash of the file's contents to detect duplicates. In other words, if those files have the same file content as one already imported (as though they were copied), then Shotwell will not import them.

Note that we have an outstanding bug at http://trac.yorba.org/ticket/2587 that deals with our metadata library returning the same bogus thumbnail from two different files, generating a false positive. This is because we use an MD5 hash of the embedded thumbnail for duplicate detection as well. As that ticket discusses, we might move away from this, as it's not especially reliable.

So, my questions are: (a) Are these files in fact byte-for-byte duplicates, or (b) do they have the same embedded thumbnail, or (c) are they victims of this bug as well.

If you know they're (a), then that's designed behavior. If they're not, you can send two of them to me and I'll examine them and see what's triggering this behavior.

Regarding the NEF problem, that format should be supported by Shotwell. (I have a handful of them in my test library.) We rely on libraw (which is based off of dcraw), so it may be that these particular NEF files gave the RAW library decode problems. If you send me one of these files, I can verify this.

My email is <email address hidden>.

-- Jim