On the other hand, patch seems to be good, even for upstream.
From the merge request comment:
"""
ACTUALLY, it made little difference because the new rules:
Oct 04 09:34:46 macbook systemd-udevd[30592]: Process '/usr/bin/sg_inq --export --inhex=/sys/class/scsi_device/2:0:0:0/device/vpd_pg80 --raw' failed with exit code 15.
Oct 04 09:34:46 macbook systemd-udevd[30592]: Process '/usr/bin/sg_inq --export --inhex=/sys/class/scsi_device/2:0:0:0/device/vpd_pg83 --raw' failed with exit code 15.
Still don't consider USB bus exception. The rule you mentioned checks for anything (else) then /dev/sd* or /dev/sr* which is not the case for pendrives, for example. Thus, the need for me to have added:
DEVPATH=="*usb*", GOTO="sg3_utils_id_end"
because:
E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1
it the only attribute I could differentiate USB from SCSI BEFORE the actual VPD reading.
I'll suggest my change to upstream now, possibly mentioning a Forwarded item in the patches.
"""
Thanks for confirming that!
On the other hand, patch seems to be good, even for upstream.
From the merge request comment:
"""
ACTUALLY, it made little difference because the new rules:
Oct 04 09:34:46 macbook systemd- udevd[30592] : Process '/usr/bin/sg_inq --export --inhex= /sys/class/ scsi_device/ 2:0:0:0/ device/ vpd_pg80 --raw' failed with exit code 15. udevd[30592] : Process '/usr/bin/sg_inq --export --inhex= /sys/class/ scsi_device/ 2:0:0:0/ device/ vpd_pg83 --raw' failed with exit code 15.
Oct 04 09:34:46 macbook systemd-
Still don't consider USB bus exception. The rule you mentioned checks for anything (else) then /dev/sd* or /dev/sr* which is not the case for pendrives, for example. Thus, the need for me to have added:
DEVPATH=="*usb*", GOTO="sg3_ utils_id_ end"
because:
E: DEVPATH= /devices/ pci0000: 00/0000: 00:14.0/ usb1
it the only attribute I could differentiate USB from SCSI BEFORE the actual VPD reading.
I'll suggest my change to upstream now, possibly mentioning a Forwarded item in the patches.
"""