Comment 5 for bug 1974177

Revision history for this message
Dave Jones (waveform) wrote :

> * abs-path-revert.patch: Is there a bug report for it? If no, please file one. If yes, please reference it.

abs-path-revert.patch first appears in 2016 in version 0.67.0-2ubuntu2 (https://git.launchpad.net/ubuntu/+source/sbuild/commit/?h=import/0.67.0-2ubuntu2&id=5fbd980fc8930ad11dd4c21b02bbfdbd9816d6c5). Unfortunately there's no bug associated with it. I've opened one (LP: #1976257) but I'm afraid it's rather sparse on detail. I'll add it to the changelog.

> * no-pkg-mangle-deps.patch: plaese forward to Debian. This change does not hurt Debian.

The "Forwarded: not-needed" tag in no-pkg-mangle-deps.patch suggests that, at the very least, Debian are not (or should not be) interested in this patch. It is certainly true that it's setting an env variable that shouldn't affect Debian as pkgbinarymangler is Ubuntu-specific. However, I'd be extremely surprised if Debian would be interested in accepting a change which has the potential to affect them in future without any present justification beyond Ubuntu having a smaller delta.

> * Can you adjust verify_deb to support gzip and xzst? Then this part can be upstreamed.

In this case it isn't a change from gzip to xz (both of which Debian support as compressors for the archives within a deb), but a change from xz to zst. The latter is not currently supported in Debian's dpkg. However, I've reviewed the current status of the relevant threads [1][2] and it seems like zstd is likely to be added to Debian at some point in the fairly near future so it makes sense to have something that fits both Debian and Ubuntu. I'll revise the patch accordingly and re-post.

[1]: https://lists.debian.org/debian-devel/2018/04/msg00653.html
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892664