On Wed, Mar 5, 2008 at 2:01 PM, shawn <email address hidden> wrote:
> I would like to work on this, I tried modifying the init script but
> status never reaches nmbd because it exits when smbd's status is found.
>
> ** Attachment added: "samba"
> http://launchpadlibrarian.net/12447200/samba
Hi there-
I'm a big fan of 'status' in init scripts--there's a bunch of places
in Ubuntu that could use some improvement there ;-)
A couple of comments and pointers...
1) Minor nit, but your whitespace in the status section is not in line
with the other case stanzas
2) Take a look at an init script that has a working status stanza, for
instance, /etc/init.d/ntp:
3) Instead of exiting 0, do like the ntp init script does, which is
print an appropriate message via log_success_msg or log_failure_msg,
and then exit with the status error code, instead of hard coding the
exit code.
On Wed, Mar 5, 2008 at 2:01 PM, shawn <email address hidden> wrote: launchpadlibrar ian.net/ 12447200/ samba
> I would like to work on this, I tried modifying the init script but
> status never reaches nmbd because it exits when smbd's status is found.
>
> ** Attachment added: "samba"
> http://
Hi there-
I'm a big fan of 'status' in init scripts--there's a bunch of places
in Ubuntu that could use some improvement there ;-)
A couple of comments and pointers...
1) Minor nit, but your whitespace in the status section is not in line
with the other case stanzas
2) Take a look at an init script that has a working status stanza, for
instance, /etc/init.d/ntp:
3) Instead of exiting 0, do like the ntp init script does, which is
print an appropriate message via log_success_msg or log_failure_msg,
and then exit with the status error code, instead of hard coding the
exit code.
Does that help?
:-Dustin