Comment 11 for bug 39157

Revision history for this message
Dustin Kirkland  (kirkland) wrote : Re: [Bug 39157] Re: Samba initscript does not conform to the LSB Spec.

On Wed, Mar 5, 2008 at 9:34 PM, Shawn Smith <email address hidden> wrote:
> I checked out the NTP init script and modified what I have, I'm still
> unsure about including nmbd though, is it necessary?
>
> ** Attachment added: "samba"
> http://launchpadlibrarian.net/12455025/samba

Hi Shawn-

First of all, your whitespace is till off. What editor are you using?

Second of all, it's very difficult to see the changes you have made to
that file. What would be much better is a file showing the
*differences*. For that, we have a utility called "diff".

You will need an unmodified samba script (hopefully you saved one),
and the one where you've made your changes. Call the old one
"samba.orig" or something. Then do:

diff -up samba.orig samba > /tmp/samba_status.patch

Have a look at that patch. It will show you the lines that you've
added (+) and the lines that you've removed (-). It will be much
easier for us to read. Also, you or anyone else can "apply" that
patch to their samba script using the "patch" utility to assume your
changes.

Do that, and post the diff here... Thanks.

:-Dustin