Comment 10 for bug 1951490

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

BTW one thing to be careful to not mix is here is minor and sub-minor version.
The patch mentions to only be for 4.15 and earlier.
This matches [1] saying "rpc_server Removed".
But while the .17 might be misleading at first it is 4.13.17 that it in focal and impish - so the .13 matters here. And those need a fix. You can also see that in the man-page which for all these (pre 4.16) will mention "Default: rpc_server:SERVER = embedded".

We can see that Upstream prepares those for the next stable releases, but not 4.13 AFAICS:

$ git log --all --grep="dcesrv_core: wrap gensec_" --oneline
# plus adding which branch they are on:
v4-16-stable 20f84f11651 dcesrv_core: wrap gensec_*() calls in [un]become_root() calls
v4-15-test e26270cbe58 dcesrv_core: wrap gensec_*() calls in [un]become_root() calls
v4-14-test 9e3c363030d dcesrv_core: wrap gensec_*() calls in [un]become_root() calls
master 0651fa474cd dcesrv_core: wrap gensec_*() calls in [un]become_root() calls
dev-branch ed345c6bc34 dcesrv_core: wrap gensec_*() calls in [un]become_root() calls

So for 4.15 (jammy) we could just wait to 4.15.6 - but then the SRU requires it to be fixed there first and we do not know when this will be released.

So the approach from here should IMHO be to prep:
9e3c363030d -> 4.13.17 -> Focal
9e3c363030d -> 4.13.17 -> Impish
e26270cbe58 -> 4.15.5 -> Jammy

Based on the backport by Marc I have prepared how I'd think a Focal upload could look like.
=> https://code.launchpad.net/~paelzer/ubuntu/+source/samba/+git/samba/+ref/fix-printing-1951490-focal

TODO:
- check and adopt my branch
- map the same for Impish and Jammy
- upload for Jammy
- Prepare SRU template
- upload to -unapproved

[1]: https://wiki.samba.org/index.php/Samba_4.16_Features_added/changed