The correct fix I think is to have the volume ID created at connection time, and stored on the connection structure, not re-built at runtime. Then we can just fail to connect if any of the functions fail (unlikely at that point).
I've confirmed the upstream codepaths in master still don't check for errors.
An upstream bug is the right thing to do, there is enough information here for an upstream filesystem developer to recognise that this isn't ideal.
At the time this feature was added in commit a27577815201101de4ca5c8375b7f768b6127fb2 (which became 1ddcc5c06aa88638ec89bb75cc7e4d3feb74efd0) it may well be that these functions couldn't fail.
The correct fix I think is to have the volume ID created at connection time, and stored on the connection structure, not re-built at runtime. Then we can just fail to connect if any of the functions fail (unlikely at that point).
I've confirmed the upstream codepaths in master still don't check for errors.
An upstream bug is the right thing to do, there is enough information here for an upstream filesystem developer to recognise that this isn't ideal.
At the time this feature was added in commit a27577815201101 de4ca5c8375b7f7 68b6127fb2 (which became 1ddcc5c06aa8863 8ec89bb75cc7e4d 3feb74efd0) it may well be that these functions couldn't fail.