© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Without any containers it (re-)starts fine:
systemctl restart smbd; sleep 2s; systemctl status smbd
● smbd.service - LSB: start Samba SMB/CIFS daemon (smbd)
Loaded: loaded (/etc/init.d/smbd; bad; vendor preset: enabled)
Active: active (running) since Tue 2018-10-09 11:58:52 UTC; 2s ago
Docs: man:systemd-
Process: 8925 ExecStop=
Process: 8932 ExecStart=
Tasks: 3
Memory: 21.7M
CPU: 200ms
CGroup: /system.
├─8943 /usr/sbin/smbd -D
├─8944 /usr/sbin/smbd -D
└─8947 /usr/sbin/smbd -D
Oct 09 11:58:52 x systemd[1]: Starting LSB: start Samba SMB/CIFS daemon (smbd)...
Oct 09 11:58:52 x smbd[8932]: * Starting SMB/CIFS daemon smbd
Oct 09 11:58:52 x smbd[8932]: ...done.
Oct 09 11:58:52 x systemd[1]: Started LSB: start Samba SMB/CIFS daemon (smbd).
But if I add a container with a smb binary it will fail to restart:
● smbd.service - LSB: start Samba SMB/CIFS daemon (smbd)
Loaded: loaded (/etc/init.d/smbd; bad; vendor preset: enabled)
Active: active (exited) since Tue 2018-10-09 12:02:41 UTC; 2s ago
Docs: man:systemd-
Process: 12732 ExecStop=
Process: 12739 ExecStart=
Oct 09 12:02:41 x systemd[1]: Starting LSB: start Samba SMB/CIFS daemon (smbd)...
Oct 09 12:02:41 x smbd[12739]: * Starting SMB/CIFS daemon smbd
Oct 09 12:02:41 x smbd[12739]: ...done.
Oct 09 12:02:41 x systemd[1]: Started LSB: start Samba SMB/CIFS daemon (smbd).
This will block (as initially reported) and be non-obvious until one realizes the process from the container is what blocks this.
Installing from proposed
root@x:~# apt install samba
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
libwbclient0 python-samba samba-common samba-common-bin samba-libs
Suggested packages:
bind9 bind9utils ctdb ldb-tools smbldap-tools winbind heimdal-clients
Recommended packages:
samba-
The following packages will be upgraded:
libwbclient0 python-samba samba samba-common samba-common-bin samba-libs
6 upgraded, 0 newly installed, 0 to remove and 23 not upgraded.
Need to get 7759 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://
Get:2 http://
Get:3 http://
Get:4 http://
Get:5 http://
Get:6 http://
Fetched 7759 kB in 1s (5118 kB/s)
Preconfiguring packages ...
(Reading database ... 47300 files and directories currently installed.)
Preparing to unpack .../python-
Unpacking python-samba (2:4.3.
Preparing to unpack .../samba-
Unpacking samba-common-bin (2:4.3.
Preparing to unpack .../samba-
Unpacking samba-libs:amd64 (2:4.3.
Preparing to unpack .../libwbclient
Unpacking libwbclient0:amd64 (2:4.3.
Preparing to unpack .../samba_
Unpacking samba (2:4.3.
Preparing to unpack .../samba-
Unpacking samba-common (2:4.3.
Processing triggers for man-db (2.7.5-1) ...
Processing triggers for libc-bin (2.23-0ubuntu10) ...
Processing triggers for systemd (229-4ubuntu21.4) ...
Processing triggers for ureadahead (0.100.0-19) ...
Processing triggers for ufw (0.35-0ubuntu2) ...
Setting up libwbclient0:amd64 (2:4.3.
Setting up samba-libs:amd64 (2:4.3.
Setting up python-samba (2:4.3.
Setting up samba-common (2:4.3.
Setting up samba-common-bin (2:4.3.
Setting up samba (2:4.3.
Installing new version of config file /etc/init.d/nmbd ...
Installing new version of config file /etc/init.
Installing new version of config file /etc/init.d/smbd ...
Processing triggers for libc-bin (2.23-0ubuntu10) ...
Processing triggers for systemd (229-4ubuntu21.4) ...
Processing triggers for ureadahead (0.100.0-19) ...
---
Trying to restart again:
# systemctl restart smbd; sleep 2s; systemctl status smbd
● smbd.service - LSB: start Samba SMB/CIFS daemon (smbd)
Loaded: loaded (/etc/init.d/smbd; bad; vendor preset: enabled)
Active: active (running) since Tue 2018-10-09 12:05:11 UTC; 2s ago
Docs: man:systemd-
Process: 14092 ExecStop=
Process: 14099 ExecStart=
Tasks: 3
Memory: 14.0M
CPU: 196ms
CGroup: /system.
├─14110 /usr/sbin/smbd -D
├─14111 /usr/sbin/smbd -D
└─14114 /usr/sbin/smbd -D
Oct 09 12:05:11 x systemd[1]: Starting LSB: start Samba SMB/CIFS daemon (smbd)...
Oct 09 12:05:11 x smbd[14099]: * Starting SMB/CIFS daemon smbd
Oct 09 12:05:11 x smbd[14099]: ...done.
Oct 09 12:05:11 x systemd[1]: Started LSB: start Samba SMB/CIFS daemon (smbd).
---
Starting a background process
md5sum /dev/urandom &
[1] 15863
# ps axlf | grep -e md5 -e smbd
0 0 15863 6310 20 0 7720 660 - R ? 1:43 \_ md5sum /dev/urandom
0 0 15919 6310 20 0 14620 984 pipe_w S+ ? 0:00 \_ grep --color=auto -e md5 -e smbd
5 0 15855 1 20 0 336632 16104 poll_s Ss ? 0:00 /usr/sbin/smbd -D
1 0 15857 15855 20 0 328524 4460 poll_s S ? 0:00 \_ /usr/sbin/smbd -D
1 0 15859 15855 20 0 336632 6312 poll_s S ? 0:00 \_ /usr/sbin/smbd -D
put the pid 15863 in /var/run/
# systemctl restart smbd; sleep 2s; systemctl status smbd
[1]+ Terminated md5sum /dev/urandom
● smbd.service - LSB: start Samba SMB/CIFS daemon (smbd)
Loaded: loaded (/etc/init.d/smbd; bad; vendor preset: enabled)
Active: active (running) since Tue 2018-10-09 12:10:00 UTC; 2s ago
Docs: man:systemd-
Process: 15923 ExecStop=
Process: 15955 ExecStart=
Tasks: 3
Memory: 7.7M
CPU: 138ms
CGroup: /system.
├─15855 /usr/sbin/smbd -D
├─15857 /usr/sbin/smbd -D
└─15859 /usr/sbin/smbd -D
Oct 09 12:10:00 x systemd[1]: Starting LSB: start Samba SMB/CIFS daemon (smbd)...
Oct 09 12:10:00 x smbd[15955]: * Starting SMB/CIFS daemon smbd
Oct 09 12:10:00 x smbd[15955]: ...done.
Oct 09 12:10:00 x systemd[1]: Started LSB: start Samba SMB/CIFS daemon (smbd).
The other process was killed AND the intended service not restarted.
After the fix this behaves like this:
ps axlf | grep -e md5 -e smbd
0 0 17341 6310 20 0 7720 764 - R ? 2:04 \_ md5sum /dev/urandom
0 0 17433 6310 20 0 14620 1092 pipe_w S+ ? 0:00 \_ grep --color=auto -e md5 -e smbd
5 0 17427 1 20 0 336632 15820 poll_s Ss ? 0:00 /usr/sbin/smbd -D
1 0 17428 17427 20 0 328524 4376 poll_s S ? 0:00 \_ /usr/sbin/smbd -D
1 0 17430 17427 20 0 336632 6536 poll_s S ? 0:00 \_ /usr/sbin/smbd -D
again putting 17341 into the pidfile to simulate a stale pidfile.
It is no more killing the wrong process by accident now.
---
Both changes working as intended now.
Also none of our tests along found issues with the changes.
Marking verified.
Note: I'd be fine to give this a few extra days in proposed just to be sure, unless there is a new security update or any such - then lets push this out before that one.