Comment 25 for bug 41355

Revision history for this message
Hans-Juergen Mauser (hjmauser) wrote : Re: [Bug 41355] Re: s3switch segfaults on the thinkpad [patch]

Hello Tormod,

here are my first test results, a little bit surprising:

1. the common results:

- on my systems with the modified savage driver (the "big patch" which I
want to divide up soon...) and the Savage IX/MX chipset, BOTH versions
of s3switch, the well-known old one from the Ubuntu repository as well
as your modified one, are actually able to modify all settings including
the TV format

- the requested TV output format gets valid at the first output switch
to TV after the setting has been changed - meaning that changing the TV
format while the output is set to TV is saved, but not changed
immediately (that is how I would expect it as an "online" change could
cause other kinds of trouble)

2. the differences:

- your modified version gives a segmentation fault on my system when it
is called with "ntsc" or "pal" - but as mentioned above, the correct
format is activated (but not printed on the screen, I hope the
segmentation fault is not caused by the printf?)

- the repository version gives me a detailed error message about a vm86
error when called with "ntsc" or "pal", with register dumps complaining
that it was not able to write the setting, but after this error message
the new setting is printed to the screen

3. hardware

- the BIOS of my system never got corrupted by s3switch, no matter how
often I switched back and forth between outputs and TV formats

If and when time allows, I will also make further tests and alsso take a
look at the source code.

Hope these first results may help you a little.