Comment 2 for bug 1990573

Thanks for this initial review Christian.

ruby-ruby2-keywords is a dependency of ruby-mustermann. I took a look at ruby-mustermann if we could easily patch it out, turns out that it is not that easy. To transition the library to ruby 3, the way upstream fixed the positional and keyword argument breaking change [1] was using the ruby2_keywords gem, this is listed by ruby interpreter upstream as one way to fix the issue without the need to write code to comply with ruby 3 changes, keeping the old code. I tried to simple remove the ruby2_keywords calls but then 3/4 of the test suite failed and it is not so straightforward to fix them throughout the code base. Upstream also supports ruby >= 2.6, so they are not willing to move away from that implementation right now.

The ruby-ruby2-keywords gem is pretty small and quite low maintenance, could we consider keeping it as a dependency of ruby-mustermann and promote it to main?

[1] https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/