Comment 8 for bug 1775673

Revision history for this message
Iain Parris (ipv2) wrote : Re: ruby-ncurses is broken in ubuntu 18.04

Thank you very much for the detailed review, Lucas!

Everything that you wrote makes perfect sense, and I would like to say a special thank you for taking the time to explain the reasoning for the modifications so clearly. I am also very grateful to you for your kind offer to take me through the process, so that we can hopefully land the fix in bionic.

Please find attached an updated patch, incorporating all of your feedback (both mandatory and recommended):

* Version string "1.4.9-1build3ubuntu0.18.04.1" (so as not to interfere with upgrades)
* debian/changelog: Use "LP: #NNNN" instead of "Closes: #NNNN"
* Add DEP-3 headers and shorten changelog entry

I have followed DEP-3 as closely as I could, e.g., using a standard "Bug-Ubuntu" header. I have also, of course, additionally credited you via a second "Reviewed-By" header.

Like for my first attempt, I have built this in pbuilder and it builds successfully. I installed it, the patch functions as intended.

I'd like to request a review for the updated debdiff please (attached). (I'd of course be happy to make any further changes needed.)

Thank you again, Lucas.