Comment 6 for bug 2063110

Revision history for this message
Dave Jones (waveform) wrote :

This looks good: a nice minimal patch, patch has proper headers and attribution, SRU template looks well written with an easy to use test-case and a reasonable regression section, and the patch is well formed with a good version number for SRU.

One minor quibble: the changelog mentions d/rules but this file isn't actually changed in the diff, it's a new patch instead. However, I'm happy to fix that on upload; sponsoring for noble.