This causes debian/rsyslog.upstart to no longer be installed, which will break everyone's logging, as far as I can see. At the very least, if this change is intentional, it needs to be explicitly documented - but it looks like a mistake.
Although I'm happy to review patches either way, you might find it easier to avoid making this kind of mistake if you did the merge in bzr?
+ - Patch the upstart job to parse /etc/default/rsyslog as the old init
+ script used to
Since the entire upstart job is one of the "remaining changes" in Ubuntu, there's no need to separately list changes to it. The entry "Replace init script with debian/rsyslog.upstart" is enough.
diff -Nru rsyslog- 5.8.0/debian/ rules rsyslog- 5.8.0/debian/ rules 5.8.0/debian/ rules 2011-04-12 14:35:18.000000000 +0200 5.8.0/debian/ rules 2011-05-02 17:57:38.000000000 +0200 example. conf
--- rsyslog-
+++ rsyslog-
@@ -30,4 +30,4 @@
dh_compress -X rsyslog-
override_ dh_installinit:
- dh_installinit -R -- start 10 2 3 4 5 . start 30 0 6 . stop 90 1 .
+ dh_installinit --upstart-only --name=dmesg --no-start
This causes debian/ rsyslog. upstart to no longer be installed, which will break everyone's logging, as far as I can see. At the very least, if this change is intentional, it needs to be explicitly documented - but it looks like a mistake.
Although I'm happy to review patches either way, you might find it easier to avoid making this kind of mistake if you did the merge in bzr?
+ - Patch the upstart job to parse /etc/default/ rsyslog as the old init
+ script used to
Since the entire upstart job is one of the "remaining changes" in Ubuntu, there's no need to separately list changes to it. The entry "Replace init script with debian/ rsyslog. upstart" is enough.