Comment 4 for bug 1464201

Revision history for this message
Martin Pitt (pitti) wrote : Re: Please merge rsyslog 8.9.0-3 (main) from Debian unstable (main)

Two more issues:

 - This is against the old version 8.9.0 which isn't even in testing any more. Can you please adjust to 8.12.0-1? (There are some patch failures)
 - "Replace debian/rsyslog.dmesg.upstart by equivalent systemd service to save initial dmesg into a file." - don't do that; we still need to keep the upstart job for touch. Under systemd you don't really need this as dmesg is saved in the journal. If you really want to add such a job, please just add it (and document it like that).
 - If you want to add/keep rsyslog-dmesg.service, please fix the unit: The After= is a no-op (unless you specify DefaultDependencies=no), the unit should be of type oneshot, and the call to savellog seems a bit pointless? I thought the idea was to keep the dmesg for the current boot only, not rotate it. Log rotation (or explicit logging) should really be a thing of the past with journal.

------------- 8< ------------
[Unit]
Description=Save kernel messages

[Service]
Type=oneshot
ExecStart=/bin/sh -ec "savelog -q -p -c 5 /var/log/dmesg;dmesg -s 524288 > /var/log/dmesg;chgrp adm /var/log/dmesg"

[Install]
WantedBy=multi-user.target
------------- 8< ------------

But again, I would like you to reconsider if this is really necessary.