Comment 25 for bug 1384503

Revision history for this message
Robie Basak (racb) wrote : Re: [Bug 1384503] Re: rsync fails on large files with compression

On Tue, Jan 03, 2017 at 05:00:09AM -0000, Haw Loeung wrote:
> rsync shipped in Xenial builds with the included zlib (--with-included-
> zlib=yes and -Izlib). Couldn't we SRU a fix doing the same thing as per
> https://bugs.launchpad.net/rsync/+bug/1300367/comments/6?

I am -1 on any SRU that does not come with a comprehensive regression
risk analysis. It's not the patch that is the problem; it is the
consideration of all interoperability permutations that needs to be made
if behaviour in this area is to be changed.

I'm not saying we can't do it; just that we need to carefully consider
what behaviour in what parts of the interoperability matrix we'd be
changing, what the regression risk is for each of those permutations,
and how to mitigate that.

It's not sufficient to say "we did it in Xenial so we can do the same in
Trusty". For example: without testing or analysis, I don't know if your
proposal breaks interoperability between Precise and Trusty when perhaps
that combination works today, or between non-updated Trusty and updated
Trusty.

My example is not exhaustive (testing just my example is not enough).

Remember also that each version combination has two directions, further
exploding the number of permutations to check. It would be OK if an
analysis convincingly collapses some of the permutations, but no such
analysis currently exists, AFAIK.