Comment 1 for bug 1898160

Revision history for this message
Dave Jones (waveform) wrote :

In the update to rpi-eeprom 10.3-1 (LP: #1906434), there's a bit more logic in rpi-eeprom-update that provides a fallback if /sys/firmware/devicetree/base/system/linux,revision doesn't exist (using /proc/cpuinfo or vcgencmd otp_dump as a last resort). For that reason, it's probably not ideal to include the ConditionPathExists suggested (it would potentially block rpi-eeprom-update from running even when it should).

I'm also not entirely convinced the service should "stay quiet" if installed on non-pi hardware. Wouldn't an admin who'd (presumably accidentally) installed this package on their arm64 non-pi hardware want to know there's a service attempting (and failing) to flash a non-existent EEPROM on their hardware?

Or is there a scenario I'm missing where installing this on arm64 non-pi hardware is expected, and leaving it installed is reasonable? If there is, I suspect something a bit more invasive may be required as /sys/.../linux,revision exists on quite a lot of arm64 non-pi hardware. What may be required is to add a Raspberry Pi specific check to /usr/bin/rpi-eeprom-update to have it exit successfully if it finds itself on such hardware (checking for a "Raspberry Pi" prefix in /sys/.../model should be sufficient).