Comment 18 for bug 1895137

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

We have assigned doko to re-review, but he is too often lost in too important bugs (e.g. today in https://bugs.launchpad.net/ubuntu/+source/fakeroot/+bug/1915250). So I want to help here by doing the re-review.

The builds of https://bugs.launchpad.net/ubuntu/+source/rpi-eeprom/+bug/1895137/comments/15 are in hirsute by now.
 raspberrypi-userland | 0~20200520+git2fe4ca3-0ubuntu3 | hirsute/universe | source

Now we need to check if all concerns were adressed:
per CL they are:
  3 * d/copyright audit
  4 * Added d/p/no-specific-libgps.patch to use whatever libgps the system
  5 provides
  6 * Excluded the various /usr/bin/containers_* test binaries from
  7 libraspberrypi-bin
  8 * Added d/librasperrypi0.symbols file
  9 * Fixed pkgconfig paths in d/p/fix-multiarch-dir.patch

I checked the changes between this and the former versions
- symbols are really present now for libraspberrypi0
  - this was a bit ugly (one pkg, many libs - no versioned names, ..)
  - but eventully the .symbols made sense, covered all
  - also I see why we need the dev-pkg-without-shlib-symlink and shlib-without-versioned-soname overrides unless we want to mess with the common filenames
- copyright was massively updated
- containers* is removed after dh_install
- test binaries are moved
- There are a few more fixes, none look concerning

This really looks mostly good by now.

Remaining Questions:
- multi-arch: foreign was requested, same it became - reason?

I've pinged Dave to clarify ...