On 11/05/2010 09:48 PM, fractal13 wrote:
> This problem is not caused by libid3tag. RipperX has an array of size 2
> to store the track number string into. So, higher than 1 digits, plus
> the null character cause the buffer to overflow. I imagine other builds
> do not have problems because they are lucky with stack frame
> construction.
>
> Attached is a patch. This works when I rebuild the package from
> sources.
>
>
> ** Patch added: "fix_2_digit_track_numbers.diff"
> https://bugs.launchpad.net/ubuntu/+source/ripperx/+bug/514739/+attachment/1724546/+files/fix_2_digit_track_numbers.diff
>
I'll take a look at your patch - thanks for that - but find it kind of
difficult to believe that this is the cause for an issue has only
recently started happening. I've been using ripperX regularly for over
5 years on Debian with CDs that have more 9 tracks and never encountered
this problem (and I still don't have the problem locally). Your success
could be related to your rebuild - i.e. perhaps some other change in the
environment/dependencies.
On 11/05/2010 09:48 PM, fractal13 wrote: digit_track_ numbers. diff" /bugs.launchpad .net/ubuntu/ +source/ ripperx/ +bug/514739/ +attachment/ 1724546/ +files/ fix_2_digit_ track_numbers. diff
> This problem is not caused by libid3tag. RipperX has an array of size 2
> to store the track number string into. So, higher than 1 digits, plus
> the null character cause the buffer to overflow. I imagine other builds
> do not have problems because they are lucky with stack frame
> construction.
>
> Attached is a patch. This works when I rebuild the package from
> sources.
>
>
> ** Patch added: "fix_2_
> https:/
>
I'll take a look at your patch - thanks for that - but find it kind of dependencies.
difficult to believe that this is the cause for an issue has only
recently started happening. I've been using ripperX regularly for over
5 years on Debian with CDs that have more 9 tracks and never encountered
this problem (and I still don't have the problem locally). Your success
could be related to your rebuild - i.e. perhaps some other change in the
environment/
Thanks,
Tony