Add support for ARM events

Bug #1741978 reported by Manoj Iyer on 2018-01-08
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rasdaemon (Debian)
Fix Released
Unknown
rasdaemon (Ubuntu)
High
Unassigned
Xenial
Undecided
Unassigned
Zesty
Undecided
Unassigned
Artful
Undecided
Unassigned

Bug Description

[IMPACT]
The UEFI 2.6 spec added support for ARM processor errors and errors
that have unrecognized CPER section types. rasdaemon needs to support ARM kernel trace events.

[FIX]
The following patches add support for ARM events to rasdaemon:

rasdaemon: add support for non standard CPER section events
rasdaemon: add support for ARM events

ARM support was added to rasdaemon in version 0.6.0 release.

[TESTING]
The patches were applied to rasdaemon 0.5.8 and 0.5.6 versions and tested on Artful and Xenial. Test results are attached to comments below.

[REGRESSION POTENTIAL]
None.

Manoj Iyer (manjo) wrote :
Manoj Iyer (manjo) wrote :

These patches were test on Artful on ARM64 system and found to work as expected. The built in test from the package was used to test rasdaemon after the patches were applied.

The attachment "rasdaemon-0.5.8 debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
dann frazier (dannf) on 2018-01-08
Changed in rasdaemon (Ubuntu):
status: New → Fix Released
summary: - [Artful/Zesty/Xenial] Add support for ARM events
+ Add support for ARM events
Manoj Iyer (manjo) wrote :

debdiff for Xenial rasdaemon-0.5.6

Manoj Iyer (manjo) wrote :

These patches were test on Xenial on ARM64 system and found to work as expected. The built in test from the package was used to test rasdaemon-0.5.6 after the patches were applied.

Changed in rasdaemon (Debian):
status: Unknown → Fix Released

Al,

I am reaching out to you to see if you could please review+apply the
debdiff for rasdaemon package, cherry-picked from upstream, and available
in debian and bionic (0.6).
https://bugs.launchpad.net/ubuntu/+source/rasdaemon/+bug/1741978 (Add
support for ARM events ). The diffs apply to 0.5.8 (Artful/Zesty) and
0.5.6 (Xenial) versions of rasdaemon.

Thanks
--
============================
Manoj Iyer
Ubuntu/Canonical
ARM Servers - Cloud
============================

Manoj Iyer (manjo) on 2018-01-19
description: updated
Manoj Iyer (manjo) wrote :

debdiff for Artful (0.5.8).

Manoj Iyer (manjo) wrote :

debdiff for Xenial (0.5.6)

Changed in rasdaemon (Ubuntu Zesty):
status: New → Won't Fix
dann frazier (dannf) wrote :

@Manoj: For the xenial one, note that you need to run 'updatemaintainer' on the package when you add the initial ubuntu1 to the version.

Manoj Iyer (manjo) wrote :

Please review the attached patch for rasdaemon 0.5.6 with changes requested by dannf.

dann frazier (dannf) on 2018-01-23
Changed in rasdaemon (Ubuntu Xenial):
status: New → In Progress
Changed in rasdaemon (Ubuntu Artful):
status: New → In Progress

Hello Manoj, or anyone else affected,

Accepted rasdaemon into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/rasdaemon/0.5.6-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in rasdaemon (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Changed in rasdaemon (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed-artful
Chris J Arges (arges) wrote :

Hello Manoj, or anyone else affected,

Accepted rasdaemon into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/rasdaemon/0.5.8-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Manoj Iyer (manjo) wrote :

Test results for -proposed testing for Xenial.

Manoj Iyer (manjo) wrote :

Test results for -proposed testing for Artful.

tags: added: verification-done verification-done-artful verification-done-xenial
removed: verification-needed verification-needed-artful verification-needed-xenial
Brian Murray (brian-murray) wrote :

I don't see a test case in the bug report so I'm not really certain what behavior this was adding or fixing, subsequently I'm not certain how to evaluate the testing attachments. Could some additional details be provided so I can feel confident about releasing this?

Robie Basak (racb) wrote :

This is blocked on a reply to Brian's comment. Please reset the tags again when done.

tags: added: verification-needed verification-needed-artful verification-needed-xenial
removed: verification-done verification-done-artful verification-done-xenial
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.