Comment 3 for bug 2073932

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Hi Jorge,

Thanks for the debdiff!

It looks mostly good; I just noticed 3 points.

I'd adjust and upload myself weren't it for point 3, which I'm unsure about.
Could you please adjust and clarify?

1) In Origin:, please use the URL for the git commit in the repository, not in its PR, as they differ.
In this instance: PR/debdiff has f8a8fb7 and merged commit is d4c95b2 [1], linked from the PR.

2) In Origin:, use used 'upstream', but there are changes from the upstream patch (file/hunk removed), so this would be 'backport' per DEP-3 [2].

+ deps/rabbit/src/rabbit_channel.erl | 9 +++++++--
+ deps/rabbit/test/queue_type_SUITE.erl | 9 +++++++++
...
+diff --git a/deps/rabbit/src/rabbit_channel.erl b/deps/rabbit/src/rabbit_channel.erl
(no other +diff line for queue_type_SUITE.erl)

3) Why is the patch file/hunk for the tests (queue_type_SUITE.erl) dropped?
If this is needed for any reason, it should be noted in the backport notes, ideally, or in Other Info.

Thanks!
Mauricio

[1] https://github.com/rabbitmq/rabbitmq-server/commit/d4c95b2be33c0a2231cf60437af1eb6d221a3b2d
[2] https://dep-team.pages.debian.net/deps/dep3/