Comment 32 for bug 43464

Revision history for this message
Kjell Braden (afflux) wrote :

Eyal,

I'm using an up-to-date ubuntu gutsy with gnome and mapped the button called "Play (or play/pause)" to a button, and pressing the button pauses and resumes the player properly for me without your patch.

Your patch introduces no real different handling since the ^= operator works exactly the same as " = not" when working with boolean values.

You can check this by typing this into a terminal:

$ python
Python 2.5.1 (r251:54863, Aug 17 2007, 18:41:48)
[GCC 4.1.3 20070812 (prerelease) (Ubuntu 4.1.2-15ubuntu2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> val1 = True
>>> val1 ^= True
>>> print val1
False
>>> val1 ^= True
>>> print val1
True
>>> val2 = True
>>> val2 = not val2
>>> print val2
False
>>> val2 = not val2
>>> print val2
True
>>>
----

Can you please check whether it really doesn't work without this patch and it does with it?