Comment 54 for bug 905147
Revision history for this message
|
|
#54 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
(In reply to comment #32)
> (In reply to comment #30)
> > My fixed patch has now been confirmed to work and fix the crash.
>
> While your patch looks sane, I don't think it has much to do with this bug.
I stand corrected: I had not looked at the attachment, but only at the diff in your comment (and in comment #30 you wrote "confirmed to work and fix the crash", but it does not only fix the crash, but actually let the dialog default to duplex - yeah!).
Your patch is exactly what I had in mind as the necessary solution, so I applied and compiled it and tried it out - IT WORKS! :-)
> (Furthermore, it should be sent to Qt, not KDE.)
This is still valid; while you might want to try applying to qt-kde, the policy is that qt-kde should deviate from upstream as few as possible!
Anyhow, thanks a lot for the patch to both Jeremy and Kevin, this really bugged me a lot!