2021-03-30 09:21:12 |
Markus Schade |
bug |
|
|
added bug |
2021-03-31 11:26:23 |
Christian Ehrhardt |
bug task added |
|
libvirt (Ubuntu) |
|
2021-03-31 11:29:39 |
Christian Ehrhardt |
libvirt (Ubuntu): status |
New |
Triaged |
|
2021-03-31 11:29:40 |
Christian Ehrhardt |
qemu (Ubuntu): status |
New |
Triaged |
|
2021-03-31 11:29:45 |
Christian Ehrhardt |
tags |
|
server-next |
|
2021-04-19 11:25:16 |
Christian Ehrhardt |
description |
QEMU added a separate model for EPYC-Milan in
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html
On the qemu side most bits are already present as far back as focal. The only things missing are the ibrs and svme-addr-chk flag.
On the libvirt side the same and fsrm (which is already in qemu)
fsrm
https://gitlab.com/libvirt/libvirt/-/commit/8c5c660b99101544d8cfcb8edbe48688c04bee25
svme-addr-chk (later patch fixed spelling)
https://gitlab.com/libvirt/libvirt/-/commit/5ac6ab2fde63881d3c5cc7372a0d0e59618feb55
ibrs
https://gitlab.com/libvirt/libvirt/-/commit/5c17a7ba41670f3182186c06e621995b5d03fc95
EPYC-Milan model
https://gitlab.com/libvirt/libvirt/-/commit/f321a4822e9fa6542e48a78611989ecd9acaa83a
https://gitlab.com/libvirt/libvirt/-/commit/d3de79dbfc20dc4dfc19154b16079861c542b71e
spelling fix for svme-addr-chk
https://gitlab.com/libvirt/libvirt/-/commit/b5abf9a192248b1005f63a7102d2627375d70fe5
Please consider adding/backporting these.
Of course there are a number of kernel commits, some/most listed in the qemu commit, that would need to be backported to enable all features. But even without them, this already works for the most part (tested on focal kernel 5.4.0-70). |
[Impact]
* To avoid bugs with newer Hardware and to allow users/admins to control
the KVM guests correctly we usually try to backport major CPU-
detect/control features back to at least the last LTS (currently Focal)
In SRU Terms this is under the second entry in
https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases
* In this particular case it is about Support for EPYC Milan chips
https://en.wikipedia.org/wiki/Epyc#Third_generation_Epyc_(Milan)
[Test Plan]
* First of all we'll (and have in advance) run general regression tests
* Second you'd want to run this with host-model and host-passthrough on
Rome / Milan chips to ensure no case is now falling in to a totally
dysfunctional state
* Finally migrations between old->new should be checked to work fine.
[Where problems could occur]
* This kind of "add the new type" usually only s a problem in backward-
migratebility which isn't supported anyway. Never the less the areas to
look out for is behavior on various AMD EPYC chips. To ensure that old
chips won't change in a breaking way (they might detect new features
now, but not more) and that new Milan chips are now all detected
properly.
[Other Info]
* This is not the first time new AMD chips need to add their definitions,
for example bug 1887490 was similar
----
QEMU added a separate model for EPYC-Milan in
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html
On the qemu side most bits are already present as far back as focal. The only things missing are the ibrs and svme-addr-chk flag.
On the libvirt side the same and fsrm (which is already in qemu)
fsrm
https://gitlab.com/libvirt/libvirt/-/commit/8c5c660b99101544d8cfcb8edbe48688c04bee25
svme-addr-chk (later patch fixed spelling)
https://gitlab.com/libvirt/libvirt/-/commit/5ac6ab2fde63881d3c5cc7372a0d0e59618feb55
ibrs
https://gitlab.com/libvirt/libvirt/-/commit/5c17a7ba41670f3182186c06e621995b5d03fc95
EPYC-Milan model
https://gitlab.com/libvirt/libvirt/-/commit/f321a4822e9fa6542e48a78611989ecd9acaa83a
https://gitlab.com/libvirt/libvirt/-/commit/d3de79dbfc20dc4dfc19154b16079861c542b71e
spelling fix for svme-addr-chk
https://gitlab.com/libvirt/libvirt/-/commit/b5abf9a192248b1005f63a7102d2627375d70fe5
Please consider adding/backporting these.
Of course there are a number of kernel commits, some/most listed in the qemu commit, that would need to be backported to enable all features. But even without them, this already works for the most part (tested on focal kernel 5.4.0-70). |
|
2021-04-19 12:02:37 |
Christian Ehrhardt |
description |
[Impact]
* To avoid bugs with newer Hardware and to allow users/admins to control
the KVM guests correctly we usually try to backport major CPU-
detect/control features back to at least the last LTS (currently Focal)
In SRU Terms this is under the second entry in
https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases
* In this particular case it is about Support for EPYC Milan chips
https://en.wikipedia.org/wiki/Epyc#Third_generation_Epyc_(Milan)
[Test Plan]
* First of all we'll (and have in advance) run general regression tests
* Second you'd want to run this with host-model and host-passthrough on
Rome / Milan chips to ensure no case is now falling in to a totally
dysfunctional state
* Finally migrations between old->new should be checked to work fine.
[Where problems could occur]
* This kind of "add the new type" usually only s a problem in backward-
migratebility which isn't supported anyway. Never the less the areas to
look out for is behavior on various AMD EPYC chips. To ensure that old
chips won't change in a breaking way (they might detect new features
now, but not more) and that new Milan chips are now all detected
properly.
[Other Info]
* This is not the first time new AMD chips need to add their definitions,
for example bug 1887490 was similar
----
QEMU added a separate model for EPYC-Milan in
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html
On the qemu side most bits are already present as far back as focal. The only things missing are the ibrs and svme-addr-chk flag.
On the libvirt side the same and fsrm (which is already in qemu)
fsrm
https://gitlab.com/libvirt/libvirt/-/commit/8c5c660b99101544d8cfcb8edbe48688c04bee25
svme-addr-chk (later patch fixed spelling)
https://gitlab.com/libvirt/libvirt/-/commit/5ac6ab2fde63881d3c5cc7372a0d0e59618feb55
ibrs
https://gitlab.com/libvirt/libvirt/-/commit/5c17a7ba41670f3182186c06e621995b5d03fc95
EPYC-Milan model
https://gitlab.com/libvirt/libvirt/-/commit/f321a4822e9fa6542e48a78611989ecd9acaa83a
https://gitlab.com/libvirt/libvirt/-/commit/d3de79dbfc20dc4dfc19154b16079861c542b71e
spelling fix for svme-addr-chk
https://gitlab.com/libvirt/libvirt/-/commit/b5abf9a192248b1005f63a7102d2627375d70fe5
Please consider adding/backporting these.
Of course there are a number of kernel commits, some/most listed in the qemu commit, that would need to be backported to enable all features. But even without them, this already works for the most part (tested on focal kernel 5.4.0-70). |
[Impact]
* To avoid bugs with newer Hardware and to allow users/admins to control
the KVM guests correctly we usually try to backport major CPU-
detect/control features back to at least the last LTS (currently Focal)
In SRU Terms this is under the second entry in
https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases
* In this particular case it is about Support for EPYC Milan chips
https://en.wikipedia.org/wiki/Epyc#Third_generation_Epyc_(Milan)
[Test Plan]
* First of all we'll (and have in advance) run general regression tests
* Second you'd want to run this with host-model and host-passthrough on
Rome / Milan chips to ensure no case is now falling in to a totally
dysfunctional state
* Qemu shall show to be aware of the new types
# qemu-system-x86_64 -cpu ? | grep EPYC-Milan
x86 EPYC-Milan (alias configured by machine type)
x86 EPYC-Milan-v1 AMD EPYC-Milan Processor
* Finally migrations between old->new should be checked to work fine.
[Where problems could occur]
* This kind of "add the new type" usually only s a problem in backward-
migratebility which isn't supported anyway. Never the less the areas to
look out for is behavior on various AMD EPYC chips. To ensure that old
chips won't change in a breaking way (they might detect new features
now, but not more) and that new Milan chips are now all detected
properly.
[Other Info]
* This is not the first time new AMD chips need to add their definitions,
for example bug 1887490 was similar
----
QEMU added a separate model for EPYC-Milan in
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html
On the qemu side most bits are already present as far back as focal. The only things missing are the ibrs and svme-addr-chk flag.
On the libvirt side the same and fsrm (which is already in qemu)
fsrm
https://gitlab.com/libvirt/libvirt/-/commit/8c5c660b99101544d8cfcb8edbe48688c04bee25
svme-addr-chk (later patch fixed spelling)
https://gitlab.com/libvirt/libvirt/-/commit/5ac6ab2fde63881d3c5cc7372a0d0e59618feb55
ibrs
https://gitlab.com/libvirt/libvirt/-/commit/5c17a7ba41670f3182186c06e621995b5d03fc95
EPYC-Milan model
https://gitlab.com/libvirt/libvirt/-/commit/f321a4822e9fa6542e48a78611989ecd9acaa83a
https://gitlab.com/libvirt/libvirt/-/commit/d3de79dbfc20dc4dfc19154b16079861c542b71e
spelling fix for svme-addr-chk
https://gitlab.com/libvirt/libvirt/-/commit/b5abf9a192248b1005f63a7102d2627375d70fe5
Please consider adding/backporting these.
Of course there are a number of kernel commits, some/most listed in the qemu commit, that would need to be backported to enable all features. But even without them, this already works for the most part (tested on focal kernel 5.4.0-70). |
|
2021-04-19 12:10:18 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401372 |
|
2021-04-19 12:10:18 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/401371 |
|
2021-04-19 12:10:35 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401373 |
|
2021-04-19 12:10:45 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/401374 |
|
2021-04-19 12:11:12 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401376 |
|
2021-04-19 12:11:17 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/401377 |
|
2021-04-22 21:27:28 |
Brian Murray |
libvirt (Ubuntu Hirsute): status |
Triaged |
Fix Committed |
|
2021-04-22 21:27:30 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2021-04-22 21:27:33 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
2021-04-22 21:27:37 |
Brian Murray |
tags |
server-next |
server-next verification-needed verification-needed-hirsute |
|
2021-04-22 21:31:30 |
Brian Murray |
qemu (Ubuntu Hirsute): status |
Triaged |
Fix Committed |
|
2021-04-23 05:59:28 |
Markus Schade |
tags |
server-next verification-needed verification-needed-hirsute |
server-next verification-done-hirsute verification-needed |
|
2021-04-23 06:35:43 |
Christian Ehrhardt |
tags |
server-next verification-done-hirsute verification-needed |
server-next verification-done verification-done-hirsute |
|
2021-04-23 07:25:57 |
Launchpad Janitor |
qemu (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
2021-04-23 07:26:14 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
2021-04-23 07:28:13 |
Launchpad Janitor |
libvirt (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
2021-04-23 07:48:45 |
Robie Basak |
qemu (Ubuntu Groovy): status |
New |
Fix Committed |
|
2021-04-23 07:48:46 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2021-04-23 07:48:50 |
Robie Basak |
tags |
server-next verification-done verification-done-hirsute |
server-next verification-done-hirsute verification-needed verification-needed-groovy |
|
2021-04-23 07:49:22 |
Robie Basak |
qemu (Ubuntu Focal): status |
New |
Fix Committed |
|
2021-04-23 07:49:26 |
Robie Basak |
tags |
server-next verification-done-hirsute verification-needed verification-needed-groovy |
server-next verification-done-hirsute verification-needed verification-needed-focal verification-needed-groovy |
|
2021-04-23 07:51:49 |
Robie Basak |
libvirt (Ubuntu Groovy): status |
New |
Fix Committed |
|
2021-04-23 07:52:21 |
Robie Basak |
libvirt (Ubuntu Focal): status |
New |
Fix Committed |
|
2021-04-23 15:23:24 |
Markus Schade |
tags |
server-next verification-done-hirsute verification-needed verification-needed-focal verification-needed-groovy |
server-next verification-done-focal verification-done-hirsute verification-needed verification-needed-groovy |
|
2021-04-26 09:12:30 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401771 |
|
2021-04-26 09:19:20 |
Christian Ehrhardt |
merge proposal unlinked |
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401771 |
|
|
2021-04-27 05:14:45 |
Christian Ehrhardt |
tags |
server-next verification-done-focal verification-done-hirsute verification-needed verification-needed-groovy |
server-next verification-done verification-done-focal verification-done-groovy verification-done-hirsute |
|
2021-05-06 08:34:06 |
Launchpad Janitor |
libvirt (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
2021-05-06 08:34:12 |
Launchpad Janitor |
qemu (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
2021-05-06 08:55:00 |
Launchpad Janitor |
qemu (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
2021-05-06 08:55:04 |
Launchpad Janitor |
libvirt (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
2022-08-09 14:06:47 |
Fabien Malfoy |
bug |
|
|
added subscriber Fabien Malfoy |