Comment 10 for bug 1887823

On Fri, Jul 17, 2020 at 03:43:51PM -0000, Dan Streetman wrote:
> this bug is about a file 'ui/keycodemapdb/.git', not a top-level .git
> file/dir, and the existence of that lower-level .git file does not
> affect the actual build (it only breaks dpkg-source's attempt to apply
> all patches and verify there are no local changes).
>
> the other bug is about the existence (or not) of a top-level .git
> directory, which is not related to git-ubuntu's behavior of creating a
> '..git' file/dir. (and also, the build acting differently if a top-level
> .git exists or not is itself a bug)

Ah - I see now, thanks. So this bug will be resolved if/when the qemu
source package no longer ships ui/keycodemapdb/.git?

> yep, it's a difficult choice; possibly git-ubuntu could cause a warning
> to be output after a 'git checkout' and maybe 'git reset' if it detects
> there is a '..git' file/dir that is a result of such git-ubuntu
> escaping. It was confusing to me that the build failure happened, and I
> assume would be confusing to others using git-ubuntu but building with
> traditional tooling.

This is a good idea, thanks. We already do something similar for empty
directory detection using git hooks that are set up by "git ubuntu
clone". I'd be happy to accept a bug and/or patch that does the same for
detection of /^\.\.+git/ (or whatever the exact unescaping rule is).