I agree Markus.
Not only does the Focal qemu miss the related changes, I also dived deeper through the "what exactly happened" to be sure.
The added patches I picked make it more obvious (test breaks) that we would need cpu model "stepping" ranges to work. This would add the need for much more logic change:
a8ec1d746 cpu_x86: Move and rename x86ModelCopySignatures
782be9f0a cpu_x86: Move and rename x86ModelHasSignature
7e0d351fa cpu_x86: Move and rename x86FormatSignatures
372b2cf1c cpu_x86: Introduce virCPUx86SignaturesFree
3b474c1f8 cpu_x86: Introduce virCPUx86SignatureFromCPUID
22bded201 cpu_x86: Replace 32b signatures in virCPUx86Model with a struct
c7a279499 cpu_x86: Add support for stepping part of CPU signature
... Those then in turn depend on various switches to glib g_fee allocations and such.
Unfortunately that isn't only true for my picked "Add-Cooperlake-x86-CPU-model", but also for one of the suggested changes by Markus as "Distinguish Cascadelake-Server from Skylake-Server" adds stepping='5-7'.
Let us keep them out for now (too much risk for an SRU, users strictly depending on this need to speak up to make a strong case or upgrade to newer Ubuntu versions)
---
Also the Arm vendors changes were a nice try, but break other places as not only cpu_map but much more code changes would be needed.
libvirt: CPU Driver error : internal error: Unexpected element 'vendor' in CPU map '/<<PKGBUILDDIR>>/debian/build/../../src/cpu_map/arm_vendors.xml'
I'm not going to pull the source changes to work fine with that.
Ok to postpone that to groovy where those changes are available already.
---
A new upload that worked in a local build was pushed to the PPA
I agree Markus.
Not only does the Focal qemu miss the related changes, I also dived deeper through the "what exactly happened" to be sure.
The added patches I picked make it more obvious (test breaks) that we would need cpu model "stepping" ranges to work. This would add the need for much more logic change: natures ature uresFree ureFromCPUID
a8ec1d746 cpu_x86: Move and rename x86ModelCopySig
782be9f0a cpu_x86: Move and rename x86ModelHasSign
7e0d351fa cpu_x86: Move and rename x86FormatSignatures
372b2cf1c cpu_x86: Introduce virCPUx86Signat
3b474c1f8 cpu_x86: Introduce virCPUx86Signat
22bded201 cpu_x86: Replace 32b signatures in virCPUx86Model with a struct
c7a279499 cpu_x86: Add support for stepping part of CPU signature
... Those then in turn depend on various switches to glib g_fee allocations and such.
Unfortunately that isn't only true for my picked "Add-Cooperlake -x86-CPU- model", but also for one of the suggested changes by Markus as "Distinguish Cascadelake-Server from Skylake-Server" adds stepping='5-7'.
Let us keep them out for now (too much risk for an SRU, users strictly depending on this need to speak up to make a strong case or upgrade to newer Ubuntu versions)
---
Also the Arm vendors changes were a nice try, but break other places as not only cpu_map but much more code changes would be needed. >>/debian/ build/. ./../src/ cpu_map/ arm_vendors. xml'
libvirt: CPU Driver error : internal error: Unexpected element 'vendor' in CPU map '/<<PKGBUILDDIR
I'm not going to pull the source changes to work fine with that.
Ok to postpone that to groovy where those changes are available already.
---
A new upload that worked in a local build was pushed to the PPA