© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
I agree to the case, but not fully to the fix.
The old syscall definitions came in in 2007 via [1] "Update Linux kernel syscall list" (v0.10.0)
The feature adding the timerfd was added in 2014 with [2] "linux-user: support timerfd_{create, gettime, settime} syscalls" (v2.2.0) using the wrong definitions.
Later this was fixed 2015 for arm [3] "linux-user/arm: Correct TARGET_NR_timerfd to TARGET_
No follow on fixes after that seen in upstream/master
That said things are fixed in Yakkety and later.
And the feature didn't exist in Trusty.
So only Xenial is affected.
The changes seem doable, and even if one used the old header on a backport it became the number which still is the same number. Also those headers are not meant for external use (no one links on that, and even if one would - again - it is the same number now).
Old value only used in the defines:
$ grep -Hrn 'TARGET_
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
linux-user/
That said, that LGTM - except I'd backport the official upstream fixes [3] and [4].
@Wes - would you mind outlining steps to reproduce as that is an integral part of any SRU [5]
[1]: https:/
[2]: https:/
[3]: https:/
[4]: https:/
[5]: https:/