Comment 3 for bug 1731051

Hi Sean,
thanks for the details and the suggested fix.

This is pretty much intertwined with the two bugs:
- bug 1710019 - Dannf trying to enable just said ITS feature in Xenial (for save restore)
- bug 1731066 - seems to be the same issue just on save/restore

As far as I understand the situation we want to ensure:
1. that once Dannf enables ITS support on older qemu in Xenial it is not triggering the same issue (so whatever we come up here is needed in Xenial as well if Dannf ports the other bug there)
2. That the solution to detect and not use ITS is the accepted one.

So for now I'll subscribe Dannf to be aware of this as well.

Furthermore the next step is to drive the change upstream into qemu 2.11 before backporting.
Because if we end up with multiple conditions for ITS detection we might be in a bad love triangle of LTS/UCA/Devel.
Therefore since you can test it and wrote the change I wanted to ask you Sean if you want to drive this into qemu upstream or if you want me to try to do so?
The change itself LGTM on a logical level, some whitespace damage thou.

Actually do you want/need a ppa with that?
Without checking any further I have thrown something into [1] - but no guarantees on build/work.
Just a polished version of your patch - but we can iterate on that as needed.

Once in Qemu we can check were we backport the fix and if it has to be prior or combined to the fixes in discussion at 1710019.

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3032/+packages