Comment 4 for bug 1705743

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks Sergeev, that is an interesting insight.

$ mkdir /tmp/service
# works
$ qemu-system-x86_64 -enable-kvm -vnc unix:/tmp/service/vnc-sock
# fails
$ qemu-system-x86_64 -enable-kvm -vnc unix:/tmp/service/../service/../service/../service/vnc-sock

And while these are running in another shell run:
$ socat - UNIX:/tmp/service/vnc-sock

Checked a few versions:
Qemu 2.10.1 works
Qemu 2.8.0 fails.
Qemu 2.5.0 fails.

A few potential fixes that come to mind, but unfortunately in Summer 2016 there were quite some rewrites int the area. So for the regression risk we should really only identify those needed and carefully review that (instead of picking more fixes along).

Iused gdb on a crashing qemu and found it really is exactly what this fixes:
  3e7f136d vnc: fix crash when vnc_server_info_get has an error

This change is nice and clean and should address the issue.
I build a test ppa at [1] which we can check later if it fixes the issue.

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3245