Comment 10 for bug 1677552
Revision history for this message
| bugproxy (bugproxy) wrote Comment bridged from LTC Bugzilla | #10 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0f7b58d
(Get the code!)
------- Comment From <email address hidden> 2017-05-22 16:42 EDT-------
Update: the review process of the patch set is still ongoing in the QEMU mailing list. The reason is that we're taking the opportunity to do required clean-ups in the existing code, such as removing the code that implemented the event_scan interface RTAS stub, consolidating functions and so on. The patch set was also split in two.
The design choice that took considerable time was how to eliminate the opaque elements that couldn't be migrated. CPU unplug and PCI unplug are unafected by it, but it directly impacts memory (LMB) unplug code. LMB unplug requires the release of several DRCs for each DIMM and the state of this removal must be somehow preserved for each callback call - today this is done by the opaque argument. The design went from doing a full LMB scan inside the callback every time to migrating the information and finally the design we have today :recoving the state of the released DIMMs only if it got erased in the migration process.
One of the new clean up patches (removing the RTAS event_scan stub) was already accepted in ppc-for-2.10 branch. I expect that this week will be the final adjustments for both patch sets.
Daniel