Comment 6 for bug 847748

Revision history for this message
Jonathan Thomas (echidnaman) wrote : [libqapt] utils/qapt-gst-helper: QGst::Caps::fromString() can return null if no caps are found for a particular string.

Git commit 42df5936b33000dde9c7ecd6eb9206ae549933a7 by Jonathan Thomas.
Committed on 14/09/2011 at 23:24.
Pushed by jmthomas into branch 'master'.

QGst::Caps::fromString() can return null if no caps are found for a particular string.
Check this return value, rather than assuming it works and crashing.

CCMAIL:<email address hidden>

M +1 -1 utils/qapt-gst-helper/GstMatcher.cpp

http://commits.kde.org/libqapt/42df5936b33000dde9c7ecd6eb9206ae549933a7

diff --git a/utils/qapt-gst-helper/GstMatcher.cpp b/utils/qapt-gst-helper/GstMatcher.cpp
index a1a4347..6527571 100644
--- a/utils/qapt-gst-helper/GstMatcher.cpp
+++ b/utils/qapt-gst-helper/GstMatcher.cpp
@@ -89,7 +89,7 @@ GstMatcher::GstMatcher(const QStringList &values)
             }

             QGst::CapsPtr caps = QGst::Caps::fromString(capsString);
- if (caps->isEmpty()) {
+ if (!caps || caps->isEmpty()) {
                 continue;
             }