As Dan mentioned, I wouldn't be comfortable sponsoring this upload without a automated test case. I believe it is a good idea to make sure the code changes are doing what we expect them to do. The upstream commit has some tests, couldn't you use some of that in your patch?
Thanks for the updated patch Eero!
As Dan mentioned, I wouldn't be comfortable sponsoring this upload without a automated test case. I believe it is a good idea to make sure the code changes are doing what we expect them to do. The upstream commit has some tests, couldn't you use some of that in your patch?