Comment 14 for bug 1893935

Revision history for this message
James Page (james-page) wrote :

[Summary]
LGTM +1 for promotion to main.

List of specific binary packages to be promoted to main: python3-virtageclient

Notes:
-doc package does not need to be promoted to main.

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
no other Dependencies to MIR due to this

NOTE:
-doc package does not need to be pulled into main.

[Embedded sources and static linking]
OK:
no embedded source present
no static linking

[Security]
OK:
history of CVEs does not look concerning
does not run a daemon as root
does not use webkit1,2
does not use lib*v8 directly
does not parse data formats
does not open a port
does not process arbitrary web content
does not use centralized online accounts
does not integrate arbitrary javascript into the desktop
does not deal with system authentication (eg, pam), etc)

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
does have a test suite that runs as autopkgtest
The package has a team bug subscriber
no translation present, but none needed for this case (user visible)?
no new python2 dependency
Python package that is using dh_python

[Packaging red flags]
OK:
Ubuntu does carry a delta, but it is reasonable and maintenance under control
symbols tracking not applicable for this kind of code.
d/watch is present and looks ok
Upstream update history is good
Debian/Ubuntu update history is good
the current release is packaged
promoting this does not seem to cause issues for MOTUs that so far
maintained the package
no massive Lintian warnings
d/rules is rather clean
Does not have Built-Using

[Upstream red flags]
OK:
no Errors/warnings during the build
no incautious use of malloc/sprintf (as far as I can check it)
no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
no use of user nobody
no use of setuid
no important open bugs (crashers, etc) in Debian or Ubuntu
no dependency on webkit, qtwebkit, seed or libgoa-*
not part of the UI for extra checks