Comment 1 for bug 1472953

Revision history for this message
Michael Terry (mterry) wrote :

So this apparently is a fork of the 'rtslib' source package. It adds python3 support and seems to be packaged better. So that's OK.

It looks OK packaging wise. It calls update-alternatives --remove in the postrm script, which is bad [1], but since it also calls it in the prerm script, I think that's fine.

I'm not super thrilled with adding a redundant iSCSI option. But I understand your reasoning. Since this runs a daemon I'll ask the security team to take a look, and they can comment on how much they'd hate supporting two iSCSI solutions.

[1] https://lintian.debian.org/tags/maintainer-script-should-not-use-update-alternatives-remove.html